+1 (non binding) Regards JB
On Wed, Jan 15, 2025 at 5:59 PM Russell Spitzer <russell.spit...@gmail.com> wrote: > > Hi Everyone! > > PR: https://github.com/apache/iceberg/pull/11976/files > > Split out from #11948 > > Working on the row-lineage implementation made it clear that we needed a way > to get information from the Snapshot object propagated into the Metadata > layer. Specifically we need to know the count of all newly added rows in that > Snapshot to change the last-row-id of the TableMetadata. While we can > potentially read this from Snapshot Summary, it would be a bit odd to have a > requirement on key value pair within Snapshot summary. We could also > potentially re-read and calculate the number of added rows, but this would > require re-opening the manifest list itself. > > I believe it makes more sense to formally have added-rows as an optional > field within the Snapshot itself so we can make it clear in the spec this > value is expected to be stored within the Snapshot metadata if row-lineage is > enabled. > > > Please take a look at the PR and signal vote or not you approve of adding > this additional field to Snapshot
