+1 (non-binding) On Wed, Jan 15, 2025 at 10:51 PM Gang Wu <ust...@gmail.com> wrote:
> +1 (non-binding) > > On Thu, Jan 16, 2025 at 2:30 PM Péter Váry <peter.vary.apa...@gmail.com> > wrote: > >> +1 >> >> Steven Wu <stevenz...@gmail.com> ezt írta (időpont: 2025. jan. 16., Cs, >> 0:46): >> >>> +1 >>> >>> On Wed, Jan 15, 2025 at 9:00 AM Russell Spitzer < >>> russell.spit...@gmail.com> wrote: >>> >>>> Hi Everyone! >>>> >>>> PR: https://github.com/apache/iceberg/pull/11976/files >>>> >>>> Split out from #11948 <https://github.com/apache/iceberg/pull/11948> >>>> >>>> Working on the row-lineage implementation made it clear that we needed >>>> a way to get information from the Snapshot object propagated into the >>>> Metadata layer. Specifically we need to know the count of all newly added >>>> rows in that Snapshot to change the last-row-id of the TableMetadata. >>>> While we can potentially read this from Snapshot Summary, it would be a bit >>>> odd to have a requirement on key value pair within Snapshot summary. We >>>> could also potentially re-read and calculate the number of added rows, but >>>> this would require re-opening the manifest list itself. >>>> >>>> I believe it makes more sense to formally have added-rows as an >>>> optional field within the Snapshot itself so we can make it clear in the >>>> spec this value is expected to be stored within the Snapshot metadata if >>>> row-lineage is enabled. >>>> >>>> >>>> Please take a look at the PR and signal vote or not you approve of >>>> adding this additional field to Snapshot >>>> >>>
