Hi Kevin, Yes, that approach sounds good to me as well. And thanks for the explanation!
Sung On Wed, Nov 27, 2024 at 8:17 PM Kevin Liu <kevinjq...@apache.org> wrote: > Hey Sung, > > Good point. For context, I accidentally generated and uploaded to PyPi a > version with `0.8.1` instead of `0.8.1rc1`. Fokko helped me yank that > version. https://pypi.org/project/pyiceberg/0.8.1/ > > If this RC passes, we can un-yank and reuse the currently uploaded > version. Otherwise, I can create a new patch version using `0.8.2`. How > does that sound? > > Additionally, I created a PR to prevent this from happening again. > https://github.com/apache/iceberg-python/pull/1386 > > Best, > Kevin Liu > > On Wed, Nov 27, 2024 at 5:07 PM Sung Yun <sungwy...@gmail.com> wrote: > >> Hi Kevin, >> >> Thank you so much for working on this release! >> >> I noticed this morning that PyIceberg 0.8.1 was released and yanked[1] >> this morning. Similar to how we had handled it when this had happened last >> time, I think this would mean that we would need to now move on to the next >> version and publish it as a PyIceberg 0.8.2 release instead. Hence, I think >> it would make sense to start a new vote thread with the incremented version. >> >> Sung >> >> [1] https://pypi.org/project/pyiceberg/ >> >> On Wed, Nov 27, 2024 at 7:55 PM Kevin Liu <kevinjq...@apache.org> wrote: >> >>> Hi Everyone, >>> >>> I propose that we release the following RC as the official PyIceberg >>> 0.8.1 release. >>> >>> The commit ID is a051584a3684392d2db6556449eb299145d47d15 >>> >>> * This corresponds to the tag: pyiceberg-0.8.1rc1 >>> (17124779c5294cb928f3807ed539f427f9b4bd2e) >>> * >>> https://github.com/apache/iceberg-python/releases/tag/pyiceberg-0.8.1rc1 >>> * >>> https://github.com/apache/iceberg-python/tree/a051584a3684392d2db6556449eb299145d47d15 >>> >>> The release tarball, signature, and checksums are here: >>> >>> * https://dist.apache.org/repos/dist/dev/iceberg/pyiceberg-0.8.1rc1/ >>> >>> You can find the KEYS file here: >>> >>> * https://downloads.apache.org/iceberg/KEYS >>> >>> Convenience binary artifacts are staged on pypi: >>> >>> https://pypi.org/project/pyiceberg/0.8.1rc1/ >>> >>> And can be installed using: pip3 install pyiceberg==0.8.1rc1 >>> >>> Instructions for verifying a release can be found here: >>> >>> * https://py.iceberg.apache.org/verify-release/ >>> >>> High-Level Summary >>> *Breaking Changes* >>> * The `Table.name` method now returns the table name *without the >>> catalog name*, as part of a broader effort to remove catalog references >>> in PyIceberg. >>> * Replace usages of `Table.identifier` with `Table.name` in the >>> codebase >>> * Replace usages of the deprecated function >>> (`identifier_to_tuple_without_catalog`) in the codebase which removes >>> unnecessary warnings >>> >>> >>> *Bug fixes** Fix `add_files` for parquet files missing column statistics >>> * Allow leading underscore in column name used in row filter >>> * Ignore Glue and Hive tables missing the `table_type` property >>> * Write `null` in manifest list metadata when there is no >>> `parent-snapshot-id` >>> >>> >>> *Dependency Updates** Removed upper-bound restrictions on dependencies; >>> allow early testing of new versions: >>> * Remove Python library version upper bound restriction; allow Python >>> 3.13 >>> * Remove fsspec library version upper bound restriction >>> >>> >>> *Documentation Updates** Improve “how to release” documentation >>> * Included post-release steps for version 0.8.0 >>> * Included documentation updates in this patch release to reflect these >>> changes in https://py.iceberg.apache.org/ >>> >>> *Commit Summary* >>> * [36 new commits since the `0.8.0` release]( >>> https://github.com/apache/iceberg-python/compare/pyiceberg-0.8.0...acbd071375ac4cc2053435346737a3b1a64cce2e). >>> >>> * 12 new commits will be included in 0.8.1 >>> * 11 commits cherry-picked as bug fixes (listed below) >>> * 1 [commit]( >>> https://github.com/apache/iceberg-python/commit/58389dfe5cf5f6ef6ea16c47cd11408c642fafd1) >>> to bump version to `0.8.1` >>> >>> *Detailed Commits* >>> * acbd071 Write `null` when there is no parent-snapshot-id (#1383) >>> * bb078cf Add instruction for patch release (#1373) >>> * ab43c6c fix `KeyError` raised by `add_files` when parquet file doe not >>> have column stats (#1354) >>> * cc1ab2c Improve documentation for "how to release" (#1359) >>> * 64dc6fe Remove Python 3.13 upper bound restriction (#1355) >>> * d86ab6e Allow leading underscore in column name used in row filter >>> (#1358) >>> * 7a4734e Replace reference of `Table.identifier` with `Table.name` >>> (#1346) >>> * a66ddc0 Ignore tables without `table_type` from Glue and Hive (#1332) >>> * 2cbc77d Drop upper bounds for fsspec and it's implementations (#1341) >>> * 7660a5b 0.8.0 post release steps (#1334) >>> * b2f0a9e use the non-deprecated func (#1326) >>> >>> >>> Please download, verify, and test. >>> >>> Please vote in the next 72 hours. >>> [ ] +1 Release this as PyIceberg 0.8.1 >>> [ ] +0 >>> [ ] -1 Do not release this because... >>> >>> Best, >>> Kevin Liu >>> >>