I agree with Péter, that sounds like the right approach to me as well. Kind regards, Fokko
Op vr 22 nov 2024 om 07:38 schreef Péter Váry <peter.vary.apa...@gmail.com>: > I would prefer B, and only revert to A if we find that B becomes too > complicated. > > On Fri, Nov 22, 2024, 04:26 Manu Zhang <owenzhang1...@gmail.com> wrote: > >> Hi Peter, >> >> Would you be more specific on which option above do you prefer? >> >> Thanks, >> Manu >> >> On Thu, Nov 21, 2024 at 10:07 PM Péter Váry <peter.vary.apa...@gmail.com> >> wrote: >> >>> Hi Team, >>> >>> Just to clarify. Hive 3 officially doesn't support Java 11, and there >>> are no plans to release a new Hive 3 version with support. >>> By "accident" the Hive Metastore tests are running with Hive 3 with Java >>> 11, but the Hive runtime tests are not running (Starting the HiveServer >>> fails, so no tests are running) >>> Currently we don't know how Hive 4 is working from the Iceberg repo (we >>> know that the Hive community is using Iceberg 1.6.1, so this shouldn't be a >>> big issue) >>> >>> Since Hive 3 is not officially supported, I also suggest moving forward, >>> and start using Hive 4. But we need to run our tests with Hive 4 first >>> before we change the documentation. >>> >>> Thanks, >>> Peter >>> >>> Jean-Baptiste Onofré <j...@nanthrax.net> ezt írta (időpont: 2024. nov. >>> 21., Cs, 14:21): >>> >>>> Hi Manu >>>> >>>> It sounds like a plan. I think it makes sense to drop Hive 2 & 3 and >>>> encourage use of Hive 4 (mostly documentation task). >>>> >>>> Regards >>>> JB >>>> >>>> On Wed, Nov 20, 2024 at 7:19 AM Manu Zhang <owenzhang1...@gmail.com> >>>> wrote: >>>> > >>>> > Okay, let me add this option >>>> > >>>> > D. Drop Hive 2 & 3 support and suggest to use built-in Iceberg >>>> support of Hive 4 >>>> > >>>> > On Wed, Nov 20, 2024 at 2:00 PM Cheng Pan <pan3...@gmail.com> wrote: >>>> >> >>>> >> Hive 4 brings built-in support for Iceberg format, duplicated >>>> implementation in both sides look a redundant stuff. >>>> >> >>>> >> As Hive 2 and 3 do not support Java 11+, and Iceberg 1.8 requires >>>> Java 11+, the combination is invalid. How about simply dropping support for >>>> Hive 2&3 and suggesting the Hive user upgrade Hive 4 to gain the built-in >>>> Iceberg support? >>>> >> >>>> >> Thanks, >>>> >> Cheng Pan >>>> >> >>>> >> >>>> >> >>>> >> On Nov 20, 2024, at 12:47, Manu Zhang <owenzhang1...@gmail.com> >>>> wrote: >>>> >> >>>> >> Hi all, >>>> >> >>>> >> We previously reached consensus[1] to deprecate Hive 2 in 1.7 and >>>> drop in 1.8. However, when working on the removal PR[2], multiple tests >>>> failed in Hive 3 due to not supporting JDK11[3]. The fix has been >>>> back-ported to branch-3.1[4] but not released yet. As announced on Hive >>>> website, Hive 3.x is declared as End of Life so there will be no more Hive >>>> 3 release. Peter(@pvary) suggested upgrading to Hive 4 instead. On the >>>> other hand, iceberg-hive3 tests are already broken after we dropped JDK 8 >>>> support. It's not caught previously due to tests not running[6]. >>>> >> >>>> >> Based on the current situation, here are the options I can think of >>>> to move forward >>>> >> >>>> >> A. Continue to remove Hive 2 in the current PR and upgrade to Hive 4 >>>> in a separate PR. >>>> >> B. Hold on removing Hive 2 until we upgrade to Hive 4 >>>> >> C. Add source dependency[7] on Hive branch-3.1 or make a Hive 3.1 >>>> release from a forked repo. >>>> >> >>>> >> 1. https://lists.apache.org/thread/zg14b8cor4lnbyd3t4n1297y2bwb1fsg >>>> >> 2. https://github.com/apache/iceberg/pull/10996 >>>> >> 3. https://issues.apache.org/jira/browse/HIVE-21584 >>>> >> 4. https://github.com/apache/hive/commits/branch-3.1/ >>>> >> 5. https://hive.apache.org/general/downloads/ >>>> >> 6. https://github.com/apache/iceberg/pull/11584 >>>> >> 7. https://blog.gradle.org/introducing-source-dependencies >>>> >> >>>> >> Which option do you prefer? Any better alternative? >>>> >> >>>> >> Thanks, >>>> >> Manu >>>> >> >>>> >> >>>> >>>
