+1 (non-binding)

Verified checksum, signature, tests

I modified the verify_rc script to use artifacts from the apache dist
https://github.com/apache/iceberg-go/pull/205
```
dev/release/verify_rc.sh 0.1.0 2
```

Best,
Kevin Liu

On Thu, Nov 14, 2024 at 11:45 AM Jean-Baptiste Onofré <j...@nanthrax.net>
wrote:

> +1 (non binding)
>
> I checked:
> - sign and hash are good (NB: sha256 is not required anymore, sha512 is
> enough)
> - LICENSE and NOTICE are OK
> - ASF header is present
> - no binary file found in the source distribution
> - build OK on my machine
>
> Thanks !
> Regards
> JB
>
> On Thu, Nov 14, 2024 at 8:20 PM Matt Topol <zotthewiz...@gmail.com> wrote:
> >
> > RC 2 has been uploaded! Sorry about that!
> >
> >
> > On Thu, Nov 14, 2024, 1:00 PM Jean-Baptiste Onofré <j...@nanthrax.net>
> wrote:
> >>
> >> Hi Matt
> >>
> >> Can you please update the source distribution on dist.apache.org
> >> (https://dist.apache.org/repos/dist/dev/iceberg/) ?
> >> It's still the RC1 here.
> >> From an ASF standpoint, that's the only strictly required artifact.
> >>
> >> Thanks !
> >> Regards
> >> JB
> >>
> >> On Thu, Nov 14, 2024 at 12:06 AM Matt Topol <zotthewiz...@gmail.com>
> wrote:
> >> >
> >> > Hi,
> >> >
> >> > I would like to propose the following release candidate (RC2) of
> Apache Iceberg Go version v0.1.0.
> >> >
> >> > This release candidate is based on commit:
> 0921b84b53e3184a1867481bf1e1a22f5a059b5c [1]
> >> >
> >> > The source release rc2 is hosted at [2].
> >> >
> >> > Please download, verify checksums and signatures, run the unit tests,
> and vote on the release. See [3] for how to validate a release candidate.
> >> >
> >> > The vote will be open for at least 72 hours.
> >> >
> >> > [ ] +1 Release this as Apache Iceberg Go v0.1.0
> >> > [ ] +0
> >> > [ ] -1 Do not release this as Apache Iceberg Go v0.1.0 because...
> >> >
> >> > Thanks!
> >> > --Matt
> >> >
> >> > [1]:
> https://github.com/apache/iceberg-go/commit/0921b84b53e3184a1867481bf1e1a22f5a059b5c
> >> > [2]: https://github.com/apache/iceberg-go/releases/v0.1.0-rc2
> >> > [3]:
> https://github.com/apache/iceberg-go/blob/main/dev/release/README.md#verify
>

Reply via email to