Hi, Daniel > 1. I didn't find any docs on how to verify a release (just docs on how to run > a release). This would be really helpful so that we know what the expected > setup and steps. > 2. The license/header checks I did somewhat manually. I also tried using the > docker/skywalking-eyes, but I don't think that worked correctly for me. The > other projects have a dev/check-license script to simplify the process.
Those issues are my fault. I promised to implement this part but didn't manage to include it in this release. I will add them in the next one. On Mon, Feb 19, 2024, at 03:03, Daniel Weeks wrote: > +1 (binding) > > checked sigs/sums/license/build/tests > > A couple things I noticed that might make the verification process go > smoother: > 1. I didn't find any docs on how to verify a release (just docs on how to run > a release). This would be really helpful so that we know what the expected > setup and steps. > 2. The license/header checks I did somewhat manually. I also tried using the > docker/skywalking-eyes, but I don't think that worked correctly for me. The > other projects have a dev/check-license script to simplify the process. > > Other than that, everything checks out. > > -Dan > > On Sat, Feb 17, 2024 at 12:29 AM Renjie Liu <liurenjie2...@gmail.com> wrote: >> +1 non-binding. >> >> [x] Download links are valid. >> [ ] Checksums and signatures. >> [x] LICENSE/NOTICE files exist >> [x] No unexpected binary files >> [x] All source files have ASF headers >> [x] Can compile from source >> >> On Sat, Feb 17, 2024 at 6:08 AM Amogh Jahagirdar <am...@tabular.io> wrote: >>> +1 non-binding, >>> >>> Verified checksum/signatures, license/notice files, ASF headers and ran >>> build and tests. >>> >>> Thanks, >>> >>> Amogh Jahagirdar >>> >>> On Fri, Feb 16, 2024 at 10:52 AM Chojan Shang <psi...@apache.org> wrote: >>>> +1 non-binding >>>> >>>> [x] Download links are valid. >>>> [x] Checksums and signatures. >>>> [x] LICENSE/NOTICE files exist >>>> [x] No unexpected binary files >>>> [x] All source files have ASF headers >>>> [x] Can compile from source >>>> >>>> On 2024/02/15 12:52:38 Fokko Driesprong wrote: >>>> > Hello, Apache Iceberg Rust Community, >>>> > >>>> > This is a call for a vote to release Apache Iceberg Rust version 0.2.0. >>>> > >>>> > The tag to be voted on is 0.2.0-rc.1. >>>> > >>>> > This first release provides integration with the REST catalog and a lot >>>> > of >>>> > scaffolding that's needed for reading the data. >>>> > >>>> > The release candidate: >>>> > >>>> > https://dist.apache.org/repos/dist/dev/iceberg/iceberg-rust-0.2.0-rc.1/ >>>> > >>>> > Keys to verify the release candidate: >>>> > >>>> > https://downloads.apache.org/iceberg/KEYS >>>> > >>>> > Git tag for the release: >>>> > >>>> > https://github.com/apache/iceberg-rust/releases/tag/v0.2.0-rc.1 >>>> > >>>> > Please download, verify, and test. >>>> > >>>> > The VOTE will be open for at least 72 hours and until the necessary >>>> > number of votes are reached. >>>> > >>>> > [ ] +1 approve >>>> > [ ] +0 no opinion >>>> > [ ] -1 disapprove with the reason >>>> > >>>> > To learn more about Apache Iceberg, please see >>>> > https://rust.iceberg.apache.org/ >>>> > >>>> > Checklist for reference: >>>> > >>>> > [ ] Download links are valid. >>>> > [ ] Checksums and signatures. >>>> > [ ] LICENSE/NOTICE files exist >>>> > [ ] No unexpected binary files >>>> > [ ] All source files have ASF headers >>>> > [ ] Can compile from source >>>> > >>>> > More detailed checklist please refer to: >>>> > https://github.com/apache/iceberg-rust/tree/main/scripts >>>> > >>>> > To compile from the source, please refer to: >>>> > https://github.com/apache/iceberg-rust/blob/main/CONTRIBUTING.md >>>> > >>>> > Huge thanks to: Amogh Jahagirdar, Chengxu Bian, Christian Daudt, Farooq >>>> > Qaiser, JanKaul, Manu Zhang, Mark Grey, Renjie Liu, Tyler Schauer, >>>> > Xiaoyang >>>> > Liu, Xuanwo, ZENOTME, barronw, hiirrxnn, y0psolo, yi wang, zhjwpku and of >>>> > course dependabot[bot] for working on this first release! >>>> > >>>> > Here is a Python script in release to help you verify the release >>>> > candidate: >>>> > >>>> > ./scripts/verify.py >>>> > >>>> > Please consider this my +1 (binding) vote. I've ran the license checks >>>> > and >>>> > tested against the REST catalog, and it worked like a charm. Code can be >>>> > found here: >>>> > https://github.com/Fokko/hello-iceberg/blob/master/src/main.rs >>>> > >>>> > Thanks, Fokko >>>> > Xuanwo
