+1 (binding)

   - Validated checksum and signature
   - Ran RAT check
   - Built and tested in Python 3.10.5
   - Installed the rc from pypi
   - Ran pyiceberg commands

I did hit a slight issue, which was that when I didn’t specify the optional
pyarrow dependency when I installed, the CLI failed with this error:

[blue@work pyiceberg-0.3.0]$ pyiceberg --help
Traceback (most recent call last):
  File "/home/blue/.pyenv/versions/3.10.5/bin/pyiceberg", line 5, in <module>
    from pyiceberg.cli.console import run
  File 
"/home/blue/.pyenv/versions/3.10.5/lib/python3.10/site-packages/pyiceberg/cli/console.py",
line 30, in <module>
    from pyiceberg.catalog import Catalog, load_catalog
  File 
"/home/blue/.pyenv/versions/3.10.5/lib/python3.10/site-packages/pyiceberg/catalog/__init__.py",
line 39, in <module>
    from pyiceberg.table import Table
  File 
"/home/blue/.pyenv/versions/3.10.5/lib/python3.10/site-packages/pyiceberg/table/__init__.py",
line 47, in <module>
    from pyiceberg.io.pyarrow import project_table
  File 
"/home/blue/.pyenv/versions/3.10.5/lib/python3.10/site-packages/pyiceberg/io/pyarrow.py",
line 43, in <module>
    import pyarrow as pa
ModuleNotFoundError: No module named 'pyarrow'

Looks like we probably need to catch import errors. I don’t think it should
fail the release, though.

On Wed, Feb 8, 2023 at 8:44 AM Eduard Tudenhoefner <edu...@tabular.io>
wrote:

> +1 (non-binding)
>
> Verified signatures/checksums/license checks/tests and ran some manual
> tests with the REST catalog.
>
> Thanks Fokko and others, this looks great.
>
> Eduard
>
>
> On Tue, Feb 7, 2023 at 8:07 PM Daniel Weeks <dwe...@apache.org> wrote:
>
>> +1 (binding)
>>
>> Verified sig/sums/license/test (including s3)
>>
>> Ran through some manual tests using the REST Catalog and everything
>> worked as expected.
>>
>> Looks great,
>> -Dan
>>
>> On Sun, Feb 5, 2023 at 10:08 AM Jack Ye <yezhao...@gmail.com> wrote:
>>
>>> +1 (binding)
>>>
>>> Verified signature, checksum, RAT
>>>
>>> Ran unit and integration tests, plus some manual testing of Glue catalog.
>>>
>>> Best,
>>> Jack Ye
>>>
>>> On Fri, Feb 3, 2023 at 5:57 PM Prashant Singh <prashant010...@gmail.com>
>>> wrote:
>>>
>>>> +1 (non-binding) Release this as PyIceberg 0.3.0
>>>>
>>>> Verified signatures, checksums, RAT checks. Ran the unit and
>>>> integration tests as per https://py.iceberg.apache.org/verify-release/
>>>>
>>>>
>>>> Regards,
>>>>
>>>> Prashant Singh
>>>>
>>>> On Fri, Feb 3, 2023 at 5:06 PM Jahagirdar, Amogh
>>>> <jaham...@amazon.com.invalid> wrote:
>>>>
>>>>> +1 non-binding for the PyIceberg 0.3.0 release. Verified signatures,
>>>>> checksums, RAT checks. Ran the unit and integration tests.
>>>>>
>>>>>
>>>>>
>>>>> Thanks,
>>>>>
>>>>>
>>>>>
>>>>> Amogh Jahagirdar
>>>>>
>>>>>
>>>>>
>>>>> *From: *"Driesprong, Fokko" <fo...@apache.org>
>>>>> *Reply-To: *"dev@iceberg.apache.org" <dev@iceberg.apache.org>
>>>>> *Date: *Thursday, February 2, 2023 at 3:59 PM
>>>>> *To: *"dev@iceberg.apache.org" <dev@iceberg.apache.org>
>>>>> *Subject: *[EXTERNAL] [VOTE] Release Apache PyIceberg 0.3.0
>>>>>
>>>>>
>>>>>
>>>>> *CAUTION*: This email originated from outside of the organization. Do
>>>>> not click links or open attachments unless you can confirm the sender and
>>>>> know the content is safe.
>>>>>
>>>>>
>>>>>
>>>>> Hi Everyone,
>>>>>
>>>>> I propose that we release the following RC as the official PyIceberg
>>>>> 0.3.0 release. This RC ships the fixes to run the tests locally, and fixes
>>>>> the warning when running the test.
>>>>>
>>>>>
>>>>>
>>>>> Ran the tests from the tar and I can confirm that it is working.
>>>>> Please consider this my +1 (non-binding).
>>>>>
>>>>> The commit ID is cb572ac94433710b62b8e8049075bf41faa77119
>>>>>
>>>>> * This corresponds to the tag: pyiceberg-0.3.0rc2
>>>>> (3b353228c4be097f975ad75ba40b45eeb255f65e)
>>>>> * https://github.com/apache/iceberg/releases/tag/pyiceberg-0.3.0rc2
>>>>> *
>>>>> https://github.com/apache/iceberg/tree/cb572ac94433710b62b8e8049075bf41faa77119
>>>>>
>>>>> The release tarball, signature, and checksums are here:
>>>>>
>>>>> * https://dist.apache.org/repos/dist/dev/iceberg/pyiceberg-0.3.0rc2/
>>>>>
>>>>> You can find the KEYS file here:
>>>>>
>>>>> * https://dist.apache.org/repos/dist/dev/iceberg/KEYS
>>>>>
>>>>> Convenience binary artifacts are staged on pypi:
>>>>>
>>>>> https://pypi.org/project/pyiceberg/0.3.0rc2/
>>>>>
>>>>> And can be installed using: pip3 install pyiceberg==0.3.0rc2
>>>>>
>>>>> Please download, verify, and test.
>>>>>
>>>>> Please vote in the next 72 hours.
>>>>> [ ] +1 Release this as PyIceberg 0.3.0
>>>>> [ ] +0
>>>>> [ ] -1 Do not release this because...
>>>>>
>>>>>
>>>>>
>>>>> Kind regards,
>>>>>
>>>>> Fokko Driesprong
>>>>>
>>>>

-- 
Ryan Blue
Tabular

Reply via email to