I've created a fix for the warning for the 0.3.0 release: https://github.com/apache/iceberg/pull/6702 Also, created a PR to fix this on master, and also turned warnings into errors: https://github.com/apache/iceberg/pull/6703/ <https://github.com/apache/iceberg/pull/6703/>
Kind regards, Fokko Op ma 30 jan. 2023 om 15:05 schreef Driesprong, Fokko <fo...@driesprong.frl >: > Perfect, and I agree that a branch is a great idea. There is some work on > the current master branch that needs a bit more testing before releasing > that to the public. I've created a branch called pyiceberg-0.3.x > <https://github.com/apache/iceberg/tree/pyiceberg-0.3.x>. > > Kind regards, > Fokko > > Op ma 30 jan. 2023 om 08:14 schreef Jahagirdar, Amogh > <jaham...@amazon.com.invalid>: > >> Sure, happy to raise a PR! I think we’ll need to create a branch off of >> the 0.3.0 commit to update for this release, and then a separate PR with >> the change against master as well for future releases. Let me know if this >> is what you had in mind. >> >> >> >> Thanks, >> >> >> >> Amogh Jahagirdar >> >> >> >> *From: *"Driesprong, Fokko" <fo...@apache.org> >> *Reply-To: *"dev@iceberg.apache.org" <dev@iceberg.apache.org> >> *Date: *Sunday, January 29, 2023 at 10:19 PM >> *To: *"dev@iceberg.apache.org" <dev@iceberg.apache.org> >> *Subject: *RE: [EXTERNAL][VOTE] Release Apache PyIceberg 0.3.0 >> >> >> >> *CAUTION*: This email originated from outside of the organization. Do >> not click links or open attachments unless you can confirm the sender and >> know the content is safe. >> >> >> >> Thanks for running the checks Daniel, and I can confirm that those files >> are missing. I think it makes sense to add them. Amogh, do you want to >> create a PR for this? I think it would be best to just include the dev >> folder, to make sure that we don't forget to include future files. >> >> >> >> I’ll dig into the warning thrown by the test. >> >> >> >> Kind regards, >> >> Fokko >> >> >> >> >> >> Op ma 30 jan. 2023 om 02:57 schreef Jahagirdar, Amogh >> <jaham...@amazon.com.invalid>: >> >> If I’m not mistaken, I think the issue is that the release tarball is >> missing the rat-excludes file and the relevant scripts from the dev folder. >> I ran the tests by checking out the source at the release candidate tag >> which has all the relevant files. >> >> >> >> I think we should include these files in the release tarball, which would >> require another RC because of the new signature and checksum. I was looking >> at the 0.2.0 release tarball, and it looks like these files also weren’t in >> there so it seems intentional to exclude these files? >> >> >> >> Would like to get the community’s thoughts on this! >> >> >> >> Thanks, >> >> >> >> Amogh Jahagirdar >> >> >> >> *From: *Daniel Weeks <dwe...@apache.org> >> *Reply-To: *"dev@iceberg.apache.org" <dev@iceberg.apache.org> >> *Date: *Sunday, January 29, 2023 at 9:41 AM >> *To: *"dev@iceberg.apache.org" <dev@iceberg.apache.org> >> *Subject: *RE: [EXTERNAL][VOTE] Release Apache PyIceberg 0.3.0 >> >> >> >> *CAUTION*: This email originated from outside of the organization. Do >> not click links or open attachments unless you can confirm the sender and >> know the content is safe. >> >> >> >> >> >> >> >> +0 >> >> >> >> Verified sigs and sums, but ran into the following issues running through >> the verification steps: >> >> >> >> *Ran into the following error verifying the licenses. Touching the file >> fixed the issue.* >> >> $ ./dev/check-license >> Attempting to fetch rat >> Exception in thread "main" java.io.FileNotFoundException: >> /Users/dweeks/workspace/apache/releases/pyiceberg/0.3.0-rc1/pyiceberg-0.3.0/dev/.rat-excludes >> (No such file or directory) >> at java.base/java.io.FileInputStream.open0(Native Method) >> at java.base/java.io.FileInputStream.open(FileInputStream.java:216) >> at java.base/java.io.FileInputStream.<init>(FileInputStream.java:157) >> at org.apache.commons.io.FileUtils.openInputStream(FileUtils.java:2388) >> at org.apache.commons.io.FileUtils.readLines(FileUtils.java:2561) >> at org.apache.rat.Report.main(Report.java:89) >> RAT exited abnormally >> >> >> >> *One warning when running tests:* >> >> ============================================================================================================== >> warnings summary >> ============================================================================================================== >> tests/test_transforms.py:423 >> >> /Users/dweeks/workspace/apache/releases/pyiceberg/0.3.0-rc1/pyiceberg-0.3.0/tests/test_transforms.py:423: >> PytestCollectionWarning: cannot collect test class 'TestType' because it >> has a __init__ constructor (from: tests/test_transforms.py) >> class TestType(IcebergBaseModel): >> >> -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html >> >> >> >> *Verification step `make test-s3` failed with the following:* >> >> $ make test-s3 >> sh ./dev/run-minio.sh >> sh: ./dev/run-minio.sh: No such file or directory >> make: *** [test-s3] Error 127 >> >> >> >> On Wed, Jan 25, 2023 at 6:23 AM Driesprong, Fokko <fo...@apache.org> >> wrote: >> >> Hi Everyone, >> >> >> >> I propose that we release the following RC as the official PyIceberg >> 0.3.0 release. >> >> >> >> The commit ID is 2671621565cde8adda27b81d1699663f71d9b3d4 >> >> >> >> * This corresponds to the tag: pyiceberg-0.3.0rc1 >> (cf941fe6ae30fbfe98235d3799448cb9f717e1e6) >> >> * https://github.com/apache/iceberg/releases/tag/pyiceberg-0.3.0rc1 >> >> * >> https://github.com/apache/iceberg/tree/2671621565cde8adda27b81d1699663f71d9b3d4 >> >> >> >> This release has support for ID-based projections, to correctly handle >> renames and promotions, performance improvement by loading the manifests in >> parallel, and it also contains a lot of important bug fixes. >> >> >> >> The release tarball, signature, and checksums are here: >> >> >> >> * https://dist.apache.org/repos/dist/dev/iceberg/pyiceberg-0.3.0rc1/ >> >> >> >> You can find the KEYS file here: >> >> >> >> * https://dist.apache.org/repos/dist/dev/iceberg/KEYS >> >> >> >> Convenience binary artifacts are staged on pypi: >> >> >> >> https://pypi.org/project/pyiceberg/0.3.0rc1/ >> >> >> >> And can be installed using: pip3 install pyiceberg==0.3.0rc1 >> >> >> >> Instructions on how to verify the release can be found on the docs page: >> >> https://py.iceberg.apache.org/verify-release/ >> >> >> >> If there is anything, please don't hesitate to reach out. >> >> >> >> Please download, verify, and test. >> >> >> >> Please vote in the next 72 hours. >> >> [ ] +1 Release this as PyIceberg 0.3.0 >> >> [ ] +0 >> >> [ ] -1 Do not release this because... >> >> >> >> Kind regards, >> >> Fokko >> >>
