rdblue commented on code in PR #4071:
URL: https://github.com/apache/iceberg/pull/4071#discussion_r841294426
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -1343,7 +1405,7 @@ private void setBranchSnapshotInternal(Snapshot snapshot,
String branch) {
MetadataUpdate.SetSnapshotRef setRef =
(MetadataUpdate.SetSnapshotRef) update;
long snapshotId = setRef.snapshotId();
if (addedSnapshotIds.contains(snapshotId) &&
- SnapshotRef.MAIN_BRANCH.equals(setRef.name()) && snapshotId !=
currentSnapshotId) {
+ SnapshotRef.MAIN_BRANCH.equals(setRef.ref()) && snapshotId !=
currentSnapshotId) {
Review Comment:
Should we keep `name` as a synonym so we don't need to change as much?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
