rdblue commented on code in PR #4071:
URL: https://github.com/apache/iceberg/pull/4071#discussion_r841294374


##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -1022,6 +1065,15 @@ public Builder removeBranch(String branch) {
       return this;
     }
 
+    public Builder removeTag(String tag) {

Review Comment:
   Since these are so similar and we're calling them only after checking the 
type, I think it makes sense to have removeRef and setRef rather than separate 
methods by type.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to