rdblue commented on a change in pull request #6: Support customizing the 
location where data is written in Spark
URL: https://github.com/apache/incubator-iceberg/pull/6#discussion_r236416006
 
 

 ##########
 File path: spark/src/main/java/com/netflix/iceberg/spark/source/Writer.java
 ##########
 @@ -167,17 +169,12 @@ private int propertyAsInt(String property, int 
defaultValue) {
     return defaultValue;
   }
 
-  private String dataLocation() {
-    return new Path(new Path(table.location()), "data").toString();
-  }
-
   @Override
   public String toString() {
     return String.format("IcebergWrite(table=%s, type=%s, format=%s)",
         table, table.schema().asStruct(), format);
   }
 
-
 
 Review comment:
   Nit: whitespace-only change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to