rdblue commented on a change in pull request #6: Support customizing the
location where data is written in Spark
URL: https://github.com/apache/incubator-iceberg/pull/6#discussion_r236414275
##########
File path:
spark/src/main/java/com/netflix/iceberg/spark/source/IcebergSource.java
##########
@@ -89,7 +92,11 @@ public DataSourceReader createReader(DataSourceOptions
options) {
.toUpperCase(Locale.ENGLISH));
}
- return Optional.of(new Writer(table, lazyConf(), format));
+ String dataLocation = options.get(TableProperties.WRITE_NEW_DATA_LOCATION)
+ .orElse(table.properties().getOrDefault(
+ TableProperties.WRITE_NEW_DATA_LOCATION,
+ new Path(new Path(table.location()), "data").toString()));
+ return Optional.of(new Writer(table, lazyConf(), format, dataLocation));
Review comment:
Instead of adding parameters to Writer whenever a change like this is made,
I'd rather pass the options into Writer and handle these there. The
`dataLocation` method could do this work instead of moving it outside the
Writer class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
