rdblue commented on a change in pull request #6: Support customizing the location where data is written in Spark URL: https://github.com/apache/incubator-iceberg/pull/6#discussion_r236414924
########## File path: core/src/main/java/com/netflix/iceberg/TableProperties.java ########## @@ -66,4 +66,8 @@ public static final boolean OBJECT_STORE_ENABLED_DEFAULT = false; public static final String OBJECT_STORE_PATH = "write.object-storage.path"; + + // This only applies to files written after this property is set. Files previously written aren't relocated to + // reflect this parameter. + public static final String WRITE_NEW_DATA_LOCATION = "write.data.location"; Review comment: Should this property mirror the existing `write.object-storage.path` property? Maybe `write.folder-storage.path` would be better. Also, I would like to see a comment about what happens when this isn't set. That behavior should be to default to a `data` folder under the table location. These properties should be respected by all writers, so we want to have them well documented. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
