----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67485/#review205084 -----------------------------------------------------------
Fix it, then Ship it! Thanks a lot for the changes. Mostly looks good to me. Couple of minor suggestions. standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java Lines 2854 (patched) <https://reviews.apache.org/r/67485/#comment288042> this line should be moved to finally standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java Line 170 (original), 170 (patched) <https://reviews.apache.org/r/67485/#comment288047> any particular reason to change this 2? I think it will be usefull to have a batch size which is not same as number of partitions so that batching logic is exercised. - Vihang Karajgaonkar On June 19, 2018, 12:23 p.m., Peter Vary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67485/ > ----------------------------------------------------------- > > (Updated June 19, 2018, 12:23 p.m.) > > > Review request for hive, Alexander Kolbasov and Vihang Karajgaonkar. > > > Bugs: HIVE-19783 > https://issues.apache.org/jira/browse/HIVE-19783 > > > Repository: hive-git > > > Description > ------- > > Added a new getPartitionLocations method to the RawStore interface. > > Implemented getPartitionLocations in ObjectStore using JDQL. > Question: In CachedObjectStore: Shall I call rawStore.getPartitionLocations > or reimplement it using getPartitions? > > Modified dropPartitionsAndGetLocations: > - Instead of querying every partition data. Query only the locations using > the new interface method > - Removed partKeys parameter which become unneccessary > > > Diffs > ----- > > > itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java > 8f9a03fcd1 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > e88f9a5fee > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > e99f888eef > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java > bbbdf21d4b > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java > 7c3588d104 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/utils/FileUtils.java > ec9e9e2b95 > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java > 7c7429db15 > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java > e4f2a17d64 > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/MetaStoreFactoryForTests.java > 1a57df2680 > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java > e1c3dcb47f > > > Diff: https://reviews.apache.org/r/67485/diff/4/ > > > Testing > ------- > > Run the TestTablesCreateDropAlterTruncate test (partitioned table creation > and drop) > > > Thanks, > > Peter Vary > >
