----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67485/ -----------------------------------------------------------
(Updated June 7, 2018, 10:31 a.m.) Review request for hive, Alexander Kolbasov and Vihang Karajgaonkar. Changes ------- Null locations are possible. Handle those as well Bugs: HIVE-19783 https://issues.apache.org/jira/browse/HIVE-19783 Repository: hive-git Description ------- Added a new getPartitionLocations method to the RawStore interface. Implemented getPartitionLocations in ObjectStore using JDQL. Question: In CachedObjectStore: Shall I call rawStore.getPartitionLocations or reimplement it using getPartitions? Modified dropPartitionsAndGetLocations: - Instead of querying every partition data. Query only the locations using the new interface method - Removed partKeys parameter which become unneccessary Diffs (updated) ----- itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java ff97522 standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java b9f5fb8 standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java b3a8dd0 standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java f350aa9 standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java d9356b8 standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 8c3ada3 standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java f98e8de Diff: https://reviews.apache.org/r/67485/diff/2/ Changes: https://reviews.apache.org/r/67485/diff/1-2/ Testing ------- Run the TestTablesCreateDropAlterTruncate test (partitioned table creation and drop) Thanks, Peter Vary