----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67485/ -----------------------------------------------------------
Review request for hive, Alexander Kolbasov and Vihang Karajgaonkar. Bugs: HIVE-19783 https://issues.apache.org/jira/browse/HIVE-19783 Repository: hive-git Description ------- Added a new getPartitionLocations method to the RawStore interface. Implemented getPartitionLocations in ObjectStore using JDQL. Question: In CachedObjectStore: Shall I call rawStore.getPartitionLocations or reimplement it using getPartitions? Modified dropPartitionsAndGetLocations: - Instead of querying every partition data. Query only the locations using the new interface method - Removed partKeys parameter which become unneccessary Diffs ----- itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java 0cc0ae5 standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java d8b8414 standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java b15d89d standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java 283798c standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java 9da8d72 standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 0461c4e standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java b71eda4 Diff: https://reviews.apache.org/r/67485/diff/1/ Testing ------- Run the TestTablesCreateDropAlterTruncate test (partitioned table creation and drop) Thanks, Peter Vary