----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63343/#review189588 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java Lines 2829-2837 (original), 2829-2837 (patched) <https://reviews.apache.org/r/63343/#comment266734> This comments need to be updated. Way outdated. ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java Line 2845 (original), 2845 (patched) <https://reviews.apache.org/r/63343/#comment266735> Seems like this doesn't throw anymore. Can remove SemanticException. ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java Lines 2857-2862 (patched) <https://reviews.apache.org/r/63343/#comment266736> How come supporting left-semi join resulted in this needing change? How does this impact other join types. ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java Lines 8278 (patched) <https://reviews.apache.org/r/63343/#comment266739> Whats the relation b/w this and insertSelectForSemijoin() ? Do we need both ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java Lines 8545 (patched) <https://reviews.apache.org/r/63343/#comment266737> Can't expr be of type different than ExprNodeColumnDesc or ExprNodeConstantDesc? If not, need to throw in those cases. ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java Lines 8594 (patched) <https://reviews.apache.org/r/63343/#comment266738> other exprNode types? ql/src/test/queries/clientpositive/semijoin6.q Lines 18 (patched) <https://reviews.apache.org/r/63343/#comment266740> If left semi join supports null-safe join, can you also add test for: select * from tx1 u left semi join tx2 v on u.b <=> v.b; - Ashutosh Chauhan On Oct. 28, 2017, 8:06 p.m., Jesús Camacho Rodríguez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63343/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2017, 8:06 p.m.) > > > Review request for hive, Ashutosh Chauhan and Vineet Garg. > > > Bugs: HIVE-17766 > https://issues.apache.org/jira/browse/HIVE-17766 > > > Repository: hive-git > > > Description > ------- > > HIVE-17766 > > > Diffs > ----- > > itests/src/test/resources/testconfiguration.properties > a4648beae1ec18c88bab35ae3e7f9d9f202e40e5 > ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java > 3573d07e9a3bab4dabdc0b73292bd02ad05cbc89 > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java > 46493ac006d00f2e6c0054da2438c0b01c1e3fd3 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > 5ccb69ac4824a2002b2bddb1ad206cb7acd3ace3 > ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java > 4ddf1d5b5e87a43f7f606ce3c09ac295f5319333 > ql/src/test/queries/clientpositive/semijoin6.q PRE-CREATION > ql/src/test/results/clientpositive/llap/semijoin6.q.out PRE-CREATION > > > Diff: https://reviews.apache.org/r/63343/diff/5/ > > > Testing > ------- > > > Thanks, > > Jesús Camacho Rodríguez > >
