> On Oct. 26, 2017, 11:08 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java > > Lines 2136-2137 (original), 2119-2120 (patched) > > <https://reviews.apache.org/r/63343/diff/2/?file=1869813#file1869813line2136> > > > > Shall we try to get equi joins keys and populate them in operator here? > > Will it happen later in planning. > > Either way good to add a comment about this.
This is in Calcite operators, not in Hive. The reason keys are there is because semijoin extends equijoin. I do not know if they are effectively used, the logic here was pushing the computation of expressions to children project, but that seems to be happening when we trigger rewriting rules in any case, thus I do not think we need to do it here (maybe this code was written before some of the rules that take care of this were enabled in Hive?). - Jesús ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63343/#review189370 ----------------------------------------------------------- On Oct. 26, 2017, 9:26 p.m., Jesús Camacho Rodríguez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63343/ > ----------------------------------------------------------- > > (Updated Oct. 26, 2017, 9:26 p.m.) > > > Review request for hive, Ashutosh Chauhan and Vineet Garg. > > > Bugs: HIVE-17766 > https://issues.apache.org/jira/browse/HIVE-17766 > > > Repository: hive-git > > > Description > ------- > > HIVE-17766 > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java > 3573d07e9a3bab4dabdc0b73292bd02ad05cbc89 > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java > 46493ac006d00f2e6c0054da2438c0b01c1e3fd3 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > 5ccb69ac4824a2002b2bddb1ad206cb7acd3ace3 > ql/src/test/queries/clientpositive/semijoin6.q PRE-CREATION > ql/src/test/results/clientpositive/semijoin2.q.out > 2c3c5d8db3d5422f21fde020199e878b87b0507f > ql/src/test/results/clientpositive/semijoin6.q.out PRE-CREATION > > > Diff: https://reviews.apache.org/r/63343/diff/2/ > > > Testing > ------- > > > Thanks, > > Jesús Camacho Rodríguez > >
