----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63343/#review189370 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java Lines 2136-2137 (original), 2119-2120 (patched) <https://reviews.apache.org/r/63343/#comment266407> Shall we try to get equi joins keys and populate them in operator here? Will it happen later in planning. Either way good to add a comment about this. ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java Line 8257 (original), 8268 (patched) <https://reviews.apache.org/r/63343/#comment266408> comment: Adding a select operator to top of join to ensure projection of only left side columns. ql/src/test/queries/clientpositive/semijoin6.q Lines 10 (patched) <https://reviews.apache.org/r/63343/#comment266421> No need for this test. ql/src/test/queries/clientpositive/semijoin6.q Lines 14 (patched) <https://reviews.apache.org/r/63343/#comment266417> Please add explain for this query. ql/src/test/queries/clientpositive/semijoin6.q Lines 16 (patched) <https://reviews.apache.org/r/63343/#comment266415> Please add explain for this query. ql/src/test/queries/clientpositive/semijoin6.q Lines 18 (patched) <https://reviews.apache.org/r/63343/#comment266412> Please add explain for this query. ql/src/test/queries/clientpositive/semijoin6.q Lines 20 (patched) <https://reviews.apache.org/r/63343/#comment266413> Please add explain for this query. ql/src/test/queries/clientpositive/semijoin6.q Lines 22 (patched) <https://reviews.apache.org/r/63343/#comment266420> No need for this test. ql/src/test/queries/clientpositive/semijoin6.q Lines 25 (patched) <https://reviews.apache.org/r/63343/#comment266422> One more test (with explain): select * from tx1 u join tx2 v on (u.a + v.b > 400) and ((case when u.a > 3 then true when v.b > 1900 then true else false) or (coalesce(u.a) + coalesce(v.b) > 1900) and u.a = v.a ql/src/test/queries/clientpositive/semijoin6.q Lines 26 (patched) <https://reviews.apache.org/r/63343/#comment266419> No need for this test. ql/src/test/queries/clientpositive/semijoin6.q Lines 28 (patched) <https://reviews.apache.org/r/63343/#comment266418> No need for this test. - Ashutosh Chauhan On Oct. 26, 2017, 9:26 p.m., Jesús Camacho Rodríguez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63343/ > ----------------------------------------------------------- > > (Updated Oct. 26, 2017, 9:26 p.m.) > > > Review request for hive, Ashutosh Chauhan and Vineet Garg. > > > Bugs: HIVE-17766 > https://issues.apache.org/jira/browse/HIVE-17766 > > > Repository: hive-git > > > Description > ------- > > HIVE-17766 > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java > 3573d07e9a3bab4dabdc0b73292bd02ad05cbc89 > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java > 46493ac006d00f2e6c0054da2438c0b01c1e3fd3 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > 5ccb69ac4824a2002b2bddb1ad206cb7acd3ace3 > ql/src/test/queries/clientpositive/semijoin6.q PRE-CREATION > ql/src/test/results/clientpositive/semijoin2.q.out > 2c3c5d8db3d5422f21fde020199e878b87b0507f > ql/src/test/results/clientpositive/semijoin6.q.out PRE-CREATION > > > Diff: https://reviews.apache.org/r/63343/diff/2/ > > > Testing > ------- > > > Thanks, > > Jesús Camacho Rodríguez > >
