> On Aug. 24, 2016, 3:44 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java, > > line 368 > > <https://reviews.apache.org/r/50888/diff/5/?file=1483535#file1483535line368> > > > > We should throw only if hive.msck.path.validation is configured to > > throw.
Added this info to WARN message. - Rajesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50888/#review146669 ----------------------------------------------------------- On Aug. 24, 2016, 11:22 p.m., Rajesh Balamohan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50888/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2016, 11:22 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Bugs: HIVE-14462 > https://issues.apache.org/jira/browse/HIVE-14462 > > > Repository: hive-git > > > Description > ------- > > Metastore already does all the validations. Lots of MS calls are made just > before add_partitions to double check if the partitions exists. This impacts > perf when large number of partitions are present. > > > Diffs > ----- > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 3f85ca6 > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java a59b781 > ql/src/java/org/apache/hadoop/hive/ql/metadata/CheckResult.java ec9deeb > ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java > 34b76b8 > > ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHiveMetaStoreChecker.java > 3f26bcd > > Diff: https://reviews.apache.org/r/50888/diff/ > > > Testing > ------- > > > Thanks, > > Rajesh Balamohan > >
