----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50888/#review146669 -----------------------------------------------------------
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java <https://reviews.apache.org/r/50888/#comment213232> startAddPartition() also has check for MetaStoreUtils.validatePartitionNameCharacters(); which I think is useful. So, instead of completely removing startAddPartition, we may want to retain this check. ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java <https://reviews.apache.org/r/50888/#comment213236> Can you add info level log message about sizes of these 4 sets. Aids in debugging. ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java (line 363) <https://reviews.apache.org/r/50888/#comment213234> We should throw only if hive.msck.path.validation is configured to throw. - Ashutosh Chauhan On Aug. 24, 2016, 8:04 a.m., Rajesh Balamohan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50888/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2016, 8:04 a.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Bugs: HIVE-14462 > https://issues.apache.org/jira/browse/HIVE-14462 > > > Repository: hive-git > > > Description > ------- > > Metastore already does all the validations. Lots of MS calls are made just > before add_partitions to double check if the partitions exists. This impacts > perf when large number of partitions are present. > > > Diffs > ----- > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 3f85ca6 > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java a59b781 > ql/src/java/org/apache/hadoop/hive/ql/metadata/CheckResult.java ec9deeb > ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java > 34b76b8 > > ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHiveMetaStoreChecker.java > 3f26bcd > > Diff: https://reviews.apache.org/r/50888/diff/ > > > Testing > ------- > > > Thanks, > > Rajesh Balamohan > >
