----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50888/#review145122 -----------------------------------------------------------
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java <https://reviews.apache.org/r/50888/#comment211301> this check is needed, it only checks against the list itself - Sergey Shelukhin On Aug. 8, 2016, 8:38 a.m., Rajesh Balamohan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50888/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2016, 8:38 a.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Bugs: HIVE-14462 > https://issues.apache.org/jira/browse/HIVE-14462 > > > Repository: hive-git > > > Description > ------- > > Metastore already does all the validations. Lots of MS calls are made just > before add_partitions to double check if the partitions exists. This impacts > perf when large number of partitions are present. > > > Diffs > ----- > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 38c0eed > > Diff: https://reviews.apache.org/r/50888/diff/ > > > Testing > ------- > > > Thanks, > > Rajesh Balamohan > >
