----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50548/#review144006 -----------------------------------------------------------
llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapInputFormat.java (line 189) <https://reviews.apache.org/r/50548/#comment209943> if we make this final. We cannot do assignments inside methods called by ctor.. startRead() in this case. llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapInputFormat.java (line 229) <https://reviews.apache.org/r/50548/#comment209952> Moving the check before involves opening the file to get file schema which will defeat the purpose of metadata cache. I left the check inside but then moved starting the data reader to a separate init() method so that ctor invocation doesn't keep data reader open. llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/OrcColumnVectorProducer.java (line 75) <https://reviews.apache.org/r/50548/#comment209940> ah! Both objects are passed to each other. Updated. llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java (line 192) <https://reviews.apache.org/r/50548/#comment209942> Yeah. We need fileSchema at this point. llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java <https://reviews.apache.org/r/50548/#comment209941> Doing it in ctor now. - Prasanth_J On July 28, 2016, 3:38 a.m., Prasanth_J wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50548/ > ----------------------------------------------------------- > > (Updated July 28, 2016, 3:38 a.m.) > > > Review request for hive and Sergey Shelukhin. > > > Bugs: HIVE-14355 > https://issues.apache.org/jira/browse/HIVE-14355 > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > > llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapInputFormat.java > 9d16889 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/ColumnVectorProducer.java > abd4533 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/OrcColumnVectorProducer.java > 7db519c > > llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/OrcEncodedDataConsumer.java > 3dfab63 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/ReadPipeline.java > 21b1772 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java > 1dcd2cd > > Diff: https://reviews.apache.org/r/50548/diff/ > > > Testing > ------- > > > Thanks, > > Prasanth_J > >
