> On July 29, 2016, 12:55 a.m., Sergey Shelukhin wrote: > > llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapInputFormat.java, > > line 139 > > <https://reviews.apache.org/r/50548/diff/1-2/?file=1456040#file1456040line139> > > > > I thought this can be moved into init. The whole point is to not have > > the reader that needs to be explicitly checked by the caller before being > > used...
Moved this to init(). init() now returns false if schema evolution is not supported. > On July 29, 2016, 12:55 a.m., Sergey Shelukhin wrote: > > llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapInputFormat.java, > > line 259 > > <https://reviews.apache.org/r/50548/diff/1-2/?file=1456040#file1456040line259> > > > > hmmm.. is there a reason to move this from ctor? I thought the check > > could be moved to init method... is this useful in a separate method? This is moved to init() so that ctor does start the data read asynchronously. Previously startRead() will start the data start async but schema evolution check happened after reader creation. Now this is reversed, schema evolution happens first, if that fails data reading will not happen. - Prasanth_J ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50548/#review144046 ----------------------------------------------------------- On July 28, 2016, 10:07 p.m., Prasanth_J wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50548/ > ----------------------------------------------------------- > > (Updated July 28, 2016, 10:07 p.m.) > > > Review request for hive and Sergey Shelukhin. > > > Bugs: HIVE-14355 > https://issues.apache.org/jira/browse/HIVE-14355 > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > > llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapInputFormat.java > 9d16889 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/ColumnVectorProducer.java > abd4533 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/OrcColumnVectorProducer.java > 7db519c > > llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/OrcEncodedDataConsumer.java > 3dfab63 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/ReadPipeline.java > 21b1772 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java > 93c40e4 > > Diff: https://reviews.apache.org/r/50548/diff/ > > > Testing > ------- > > > Thanks, > > Prasanth_J > >
