> On Dec. 24, 2015, 12:02 a.m., Vikram Dixit Kumaraswamy wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java, > > line 120 > > <https://reviews.apache.org/r/41431/diff/2-5/?file=1172593#file1172593line120> > > > > Need a condition for the restart thread as well.
implied > On Dec. 24, 2015, 12:02 a.m., Vikram Dixit Kumaraswamy wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java, > > line 455 > > <https://reviews.apache.org/r/41431/diff/2-5/?file=1172593#file1172593line455> > > > > All of this looks a bit complicated. I still did not understand why we > > need to re-check the queue below. I think this can be simplified but now > > may not be the time for it. added comment > On Dec. 24, 2015, 12:02 a.m., Vikram Dixit Kumaraswamy wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java, > > line 460 > > <https://reviews.apache.org/r/41431/diff/2-5/?file=1172593#file1172593line460> > > > > Don't we need to refresh this session? It looks like the number of > > sessions in the queue can go down this way. closeAndReopen opens in finally - Sergey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41431/#review111805 ----------------------------------------------------------- On Dec. 23, 2015, 1:30 a.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41431/ > ----------------------------------------------------------- > > (Updated Dec. 23, 2015, 1:30 a.m.) > > > Review request for hive, Siddharth Seth and Vikram Dixit Kumaraswamy. > > > Repository: hive-git > > > Description > ------- > > see JIRA > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java d2dd9c6 > ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java 971dac9 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezJobMonitor.java f6bc19c > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java > 0d84340 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java e5df2ec > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java c066c7a > ql/src/test/org/apache/hadoop/hive/ql/exec/tez/SampleTezSessionState.java > d55c9fe > ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezSessionPool.java > 11c0325 > > Diff: https://reviews.apache.org/r/41431/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
