> On Dec. 17, 2015, 10:51 a.m., Vikram Dixit Kumaraswamy wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java, > > line 129 > > <https://reviews.apache.org/r/41431/diff/1/?file=1165599#file1165599line129> > > > > expiration queue length is fixed at 11? Shouldn't it be a configurable > > value?
that's the initial length > On Dec. 17, 2015, 10:51 a.m., Vikram Dixit Kumaraswamy wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java, > > line 245 > > <https://reviews.apache.org/r/41431/diff/1/?file=1165599#file1165599line245> > > > > Given the assertion below, you should rename this method to > > returnSessionToPool or something like that if it is guaranteed to be a pool > > session or change the assertion below. the method is on the pool, so it kind of implies you are returning to the pool what you have taken from the pool :) - Sergey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41431/#review110852 ----------------------------------------------------------- On Dec. 16, 2015, 1:57 a.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41431/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2015, 1:57 a.m.) > > > Review request for hive, Siddharth Seth and Vikram Dixit Kumaraswamy. > > > Repository: hive-git > > > Description > ------- > > see JIRA > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 243f281 > ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java 971dac9 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezJobMonitor.java f6bc19c > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java > 0d84340 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java e1a8041 > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java c066c7a > ql/src/test/org/apache/hadoop/hive/ql/exec/tez/SampleTezSessionState.java > d55c9fe > ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezSessionPool.java > 11c0325 > > Diff: https://reviews.apache.org/r/41431/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
