-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1605/
-----------------------------------------------------------
(Updated 2011-09-14 19:41:13.647029)
Review request for hive and Carl Steinbach.
Changes
-------
Added check for resultset non empty.
The full "set -v" output would be too long, also most of the rows will
different in each test setup. Hence I am suggesting not to do that. Let me know
if you disagree.
Summary
-------
The Hive server currently has the framework to process the Cli commands like
'set'. But it returns an empty schema definition for these resultsets. The
patch here is to add a getSchema() to the CommandResponse interface. The
SetProcessor is modified to build a schema object which is returned with
getSchema.
HiveServer is modified to call the getSchema for command cases as well.
This addresses bug HIVE-2398.
https://issues.apache.org/jira/browse/HIVE-2398
Diffs (updated)
-----
jdbc/src/test/org/apache/hadoop/hive/jdbc/TestJdbcDriver.java e744d11
ql/src/java/org/apache/hadoop/hive/ql/processors/CommandProcessorResponse.java
4f7f472
ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java 9ca5ca4
service/src/java/org/apache/hadoop/hive/service/HiveServer.java 95f322a
Diff: https://reviews.apache.org/r/1605/diff
Testing
-------
Tested with ODBC program to execute the set command. Ran Hive unit tests.
Thanks,
Prasad
