----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1605/#review1895 -----------------------------------------------------------
jdbc/src/test/org/apache/hadoop/hive/jdbc/TestJdbcDriver.java <https://reviews.apache.org/r/1605/#comment4376> Need to assert that the size of the resultset is > 0. Might also be good to log the contents of the resultset. - Carl On 2011-09-13 20:03:48, Prasad Mujumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1605/ > ----------------------------------------------------------- > > (Updated 2011-09-13 20:03:48) > > > Review request for hive and Carl Steinbach. > > > Summary > ------- > > The Hive server currently has the framework to process the Cli commands like > 'set'. But it returns an empty schema definition for these resultsets. The > patch here is to add a getSchema() to the CommandResponse interface. The > SetProcessor is modified to build a schema object which is returned with > getSchema. > HiveServer is modified to call the getSchema for command cases as well. > > > This addresses bug HIVE-2398. > https://issues.apache.org/jira/browse/HIVE-2398 > > > Diffs > ----- > > jdbc/src/test/org/apache/hadoop/hive/jdbc/TestJdbcDriver.java e744d11 > > ql/src/java/org/apache/hadoop/hive/ql/processors/CommandProcessorResponse.java > 4f7f472 > ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java 9ca5ca4 > service/src/java/org/apache/hadoop/hive/service/HiveServer.java 95f322a > > Diff: https://reviews.apache.org/r/1605/diff > > > Testing > ------- > > Tested with ODBC program to execute the set command. Ran Hive unit tests. > > > Thanks, > > Prasad > >
