----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1605/#review1857 -----------------------------------------------------------
Please add a testcase. Also, I tried running 'set -v' from the CLI after setting hive.cli.print.header=true, and I don't see the column name in the output. This seems like a bug? ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java <https://reviews.apache.org/r/1605/#comment4245> Checkstyle: static final variable names should appear in ALL CAPS ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java <https://reviews.apache.org/r/1605/#comment4248> bld? Might be good to change the name to getSchema. Also, since setColName is a constant there's no need for this method to have an input parameter. ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java <https://reviews.apache.org/r/1605/#comment4247> Please add static imports for STRING_TYPE_NAME, SERIALIZATION_NULL_FORMAT, and defaultNullString. service/src/java/org/apache/hadoop/hive/service/HiveServer.java <https://reviews.apache.org/r/1605/#comment4249> This comment is no longer valid. Also, it might be cleaner to remove the else clause. - Carl On 2011-08-19 22:37:45, Prasad Mujumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1605/ > ----------------------------------------------------------- > > (Updated 2011-08-19 22:37:45) > > > Review request for hive and Carl Steinbach. > > > Summary > ------- > > The Hive server currently has the framework to process the Cli commands like > 'set'. But it returns an empty schema definition for these resultsets. The > patch here is to add a getSchema() to the CommandResponse interface. The > SetProcessor is modified to build a schema object which is returned with > getSchema. > HiveServer is modified to call the getSchema for command cases as well. > > > This addresses bug HIVE-2398. > https://issues.apache.org/jira/browse/HIVE-2398 > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/processors/CommandProcessorResponse.java > 4f7f472 > ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java 97fa1ab > service/src/java/org/apache/hadoop/hive/service/HiveServer.java c4b041f > > Diff: https://reviews.apache.org/r/1605/diff > > > Testing > ------- > > Tested with ODBC program to execute the set command. Ran Hive unit tests. > > > Thanks, > > Prasad > >
