> On 2011-06-03 14:04:02, Ashutosh Chauhan wrote: > > trunk/metastore/if/hive_metastore.thrift, line 249 > > <https://reviews.apache.org/r/831/diff/1/?file=20144#file20144line249> > > > > How about calling it get_multi_table instead? multi_get_table sounds > > little confusing to me.
Ok, get_multi_table definitely sounds better. > On 2011-06-03 14:04:02, Ashutosh Chauhan wrote: > > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, > > line 521 > > <https://reviews.apache.org/r/831/diff/1/?file=20145#file20145line521> > > > > You can write this more concisely using commons-lang utility method as: > > StringUtils.join(tbls,','); Thanks for the tip; I changed this. > On 2011-06-03 14:04:02, Ashutosh Chauhan wrote: > > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, > > line 1182 > > <https://reviews.apache.org/r/831/diff/1/?file=20145#file20145line1182> > > > > You can get rid of tables.get(i) == null check that will never be true. I cleaned up the checks for seeing if the db had all the requested tables. Also, I realized that I did not guarantee returning tables in the same order as those requested, so I fixed that up too. > On 2011-06-03 14:04:02, Ashutosh Chauhan wrote: > > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, > > line 1195 > > <https://reviews.apache.org/r/831/diff/1/?file=20145#file20145line1195> > > > > Instead of throwing RuntimeException, create MetaException and throw > > that. I changed it to throw a MetaException instead. However, the other metastore operations (e.g., get_table, append_partition) throw RuntimException, which is what I based get_multi_table off. > On 2011-06-03 14:04:02, Ashutosh Chauhan wrote: > > trunk/service/src/test/org/apache/hadoop/hive/service/TestHiveServer.java, > > line 221 > > <https://reviews.apache.org/r/831/diff/1/?file=20148#file20148line221> > > > > This test really belongs in the TestMetastore or some such in metastore > > dir not in HiveServer. Thanks for the pointer and for the feedback. - Sohan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/831/#review753 ----------------------------------------------------------- On 2011-06-06 21:09:54, Sohan Jain wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/831/ > ----------------------------------------------------------- > > (Updated 2011-06-06 21:09:54) > > > Review request for hive, Paul Yang and Ashutosh Chauhan. > > > Summary > ------- > > Created a function "multi_get_table" that retrieves multiple tables on one > trip to the hive metastore, saving round trip time. > > > This addresses bug HIVE-2188. > https://issues.apache.org/jira/browse/HIVE-2188 > > > Diffs > ----- > > trunk/metastore/if/hive_metastore.thrift 1130342 > > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 1130342 > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 1130342 > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java > 1130342 > > trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java > 1130342 > > Diff: https://reviews.apache.org/r/831/diff > > > Testing > ------- > > Added a test case to testMetasore() in TestHiveServer. Also tested for speed > improvements in a client session. > > > Thanks, > > Sohan > >
