stoty commented on PR #615: URL: https://github.com/apache/httpcomponents-client/pull/615#issuecomment-2688108657
> > I can do that, but then then the only difference between the old and new classes will be the packages and the case. Machines don't care, but I see that causing grief for users. > > Don't rename old ones, only new ones. If old ones are reused maye it would be better to copy them? I wasn't clear. The classes are different, but their names are almost identical. As the Scheme is not enabled by default, users have to add some boilerplate code to enable SPNEGO at all. It is now too easy to use the old SPNegoScheme instead of the new SpnegoScheme in that boilerplate IMO. i have renamed KerberCredentials, and added a backwards compatibility subclass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
