michael-o commented on PR #615: URL: https://github.com/apache/httpcomponents-client/pull/615#issuecomment-2688047096
> Thanks for the review. I have made the suggested changes, but I am not happy with how close the old new class names are. > > I have also left KerberosCredentials alone, because it is used by both the new and old code. Should I make an identical child class with GssCredentials name ? Yes, please. Don't break old deprecated, but add new classes for the new impl. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
