I think we should create the new RC when we find the blocker issues. We can looking forward the other check result, we can add the fix of FLINK-14315 in to 1.9.1 only we find the blockers.
Best, Jincheng Till Rohrmann <trohrm...@apache.org> 于2019年10月8日周二 下午8:20写道: > FLINK-14315 has been merged into the release-1.9 branch. I've marked the > fix version of this ticket as 1.9.2. If we should create a new RC, then we > could include this fix. If this happens, then we need to update the fix > version to 1.9.1. > > Cheers, > Till > > On Tue, Oct 8, 2019 at 1:51 PM Till Rohrmann <trohrm...@apache.org> wrote: > > > If people already spent time on verifying the current RC I would also be > > fine to release the fix for FLINK-14315 with Flink 1.9.2. > > > > I will try to merge the PR as soon as possible. When I close the ticket, > I > > will update the fix version field to 1.9.2. > > > > Cheers, > > Till > > > > On Tue, Oct 8, 2019 at 4:43 AM Jark Wu <imj...@gmail.com> wrote: > > > >> Hi Zili, > >> > >> Thanks for reminding me this, because of the Chinese National Day and > >> Flink Forward Europe, > >> we didn't receive any verification on the 1.9.1 RC1. And I guess we have > >> to extend the voting time after Flink Forward. > >> So I'm fine to have FLINK-14315 and rebuild another RC. What do you > think > >> @Till @Jincheng? > >> > >> I guess FLINK-14315 will be merged soon as it is approved 4 days ago? > >> Could you help to merge it once it is passed ? @Zili Chen > >> <wander4...@gmail.com> > >> > >> Best, > >> Jark > >> > >> On Tue, 8 Oct 2019 at 09:14, Zili Chen <wander4...@gmail.com> wrote: > >> > >>> Hi Jark, > >>> > >>> I notice a critical bug[1] is marked resolved in 1.9.1 but given 1.9.1 > >>> has been cut I'd like to throw the issue here so that we're sure > >>> whether or not it is included in 1.9.1. > >>> > >>> Best, > >>> tison. > >>> > >>> [1] https://issues.apache.org/jira/browse/FLINK-14315 > >>> > >>> > >>> Jark Wu <imj...@gmail.com> 于2019年9月30日周一 下午3:25写道: > >>> > >>>> Hi everyone, > >>>> > >>>> Please review and vote on the release candidate #1 for the version > >>>> 1.9.1, > >>>> as follows: > >>>> [ ] +1, Approve the release > >>>> [ ] -1, Do not approve the release (please provide specific comments) > >>>> > >>>> > >>>> The complete staging area is available for your review, which > includes: > >>>> * JIRA release notes [1], > >>>> * the official Apache source release and binary convenience releases > to > >>>> be > >>>> deployed to dist.apache.org [2], which are signed with the key with > >>>> fingerprint E2C45417BED5C104154F341085BACB5AEFAE3202 [3], > >>>> * all artifacts to be deployed to the Maven Central Repository [4], > >>>> * source code tag "release-1.9.1-rc1" [5], > >>>> * website pull request listing the new release and adding announcement > >>>> blog > >>>> post [6]. > >>>> > >>>> The vote will be open for at least 72 hours. > >>>> Please cast your votes before *Oct. 3th 2019, 08:00 UTC*. > >>>> > >>>> It is adopted by majority approval, with at least 3 PMC affirmative > >>>> votes. > >>>> > >>>> Thanks, > >>>> Jark > >>>> > >>>> [1] > >>>> > >>>> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12346003 > >>>> [2] https://dist.apache.org/repos/dist/dev/flink/flink-1.9.1-rc1/ > >>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS > >>>> [4] > >>>> > https://repository.apache.org/content/repositories/orgapacheflink-1272/ > >>>> [5] > >>>> > >>>> > https://github.com/apache/flink/commit/4d56de81cb692c68a7d1dbfff13087a5079a8252 > >>>> [6] https://github.com/apache/flink-web/pull/274 > >>>> > >>> >