Thanks for the work Jincheng! I have moved remaining major issues to 1.8.3 except FLINK-13586.
Hi @Aljoscha Krettek <aljos...@apache.org> , is that possible to merge FLINK-13586 today? Best, Jark On Wed, 4 Sep 2019 at 10:47, jincheng sun <sunjincheng...@gmail.com> wrote: > Thanks for the udpate Jark! > > I have add the new version 1.8.3 in JIRA, could you please remark the > JIRAs(Such as FLINK-13689) which we do not want merge into the 1.8.2 > release :) > > You are right, I think FLINK-13586 is better to be contained in 1.8.2 > release! > > Thanks, > Jincheng > > > Jark Wu <imj...@gmail.com> 于2019年9月4日周三 上午10:15写道： > > > Hi all, > > > > I am very happy to say that all the blockers and critical issues for > > release 1.8.2 have been resolved! > > > > Great thanks to everyone who contribute to the release. > > > > I hope to create the first RC on Sep 05, at 10:00 UTC+8. > > If you find some other blocker issues for 1.8.2, please let me know > before > > that to account for it for the 1.8.2 release. > > > > Before cutting the RC1, I think it has chance to merge the > > ClosureCleaner.clean fix (FLINK-13586), because the review and travis are > > both passed. > > > > Cheers, > > Jark > > > > On Wed, 4 Sep 2019 at 00:45, Kostas Kloudas <kklou...@gmail.com> wrote: > > > > > Yes, I will do that Jark! > > > > > > Kostas > > > > > > On Tue, Sep 3, 2019 at 4:19 PM Jark Wu <imj...@gmail.com> wrote: > > > > > > > > Thanks Kostas for the quick fixing. > > > > > > > > However, I find that FLINK-13940 still target to 1.8.2 as a blocker. > > If I > > > > understand correctly, FLINK-13940 is aiming for a nicer and better > > > solution > > > > in the future. > > > > So should we update the fixVersion of FLINK-13940? > > > > > > > > Best, > > > > Jark > > > > > > > > On Tue, 3 Sep 2019 at 21:33, Kostas Kloudas <kklou...@gmail.com> > > wrote: > > > > > > > > > Thanks for waiting! > > > > > > > > > > A fix for FLINK-13940 has been merged on 1.8, 1.9 and the master > > under > > > > > FLINK-13941. > > > > > > > > > > Cheers, > > > > > Kostas > > > > > > > > > > On Tue, Sep 3, 2019 at 11:25 AM jincheng sun < > > sunjincheng...@gmail.com > > > > > > > > > wrote: > > > > > > > > > > > > +1 FLINK-13940 < > https://issues.apache.org/jira/browse/FLINK-13940> > > > is a > > > > > > blocker, due to loss data is very important bug, And great thanks > > for > > > > > > helping fix it Kostas! > > > > > > > > > > > > Best, Jincheng > > > > > > > > > > > > Kostas Kloudas <kklou...@gmail.com> 于2019年9月2日周一 下午7:20写道： > > > > > > > > > > > > > Hi all, > > > > > > > > > > > > > > I think this should be also considered a blocker > > > > > > > https://issues.apache.org/jira/browse/FLINK-13940. > > > > > > > It is not a regression but it can result to data loss. > > > > > > > > > > > > > > I think I can have a quick fix by tomorrow. > > > > > > > > > > > > > > Cheers, > > > > > > > Kostas > > > > > > > > > > > > > > On Mon, Sep 2, 2019 at 12:01 PM jincheng sun < > > > sunjincheng...@gmail.com > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > Thanks for all of your feedback! > > > > > > > > > > > > > > > > Hi Jark, Glad to see that you are doing what RM should doing. > > > > > > > > > > > > > > > > Only one tips here is before the RC1 all the blocker should > be > > > > > fixed, but > > > > > > > > othrers is nice to have. So you can decide when to prepare > RC1 > > > after > > > > > the > > > > > > > > blokcer is resolved. > > > > > > > > > > > > > > > > Feel free to tell me if you have any questions. > > > > > > > > > > > > > > > > Best,Jincheng > > > > > > > > > > > > > > > > Aljoscha Krettek <aljos...@apache.org> 于2019年9月2日周一 > 下午5:03写道： > > > > > > > > > > > > > > > > > I cut a PR for FLINK-13586: > > > > > https://github.com/apache/flink/pull/9595 > > > > > > > < > > > > > > > > > https://github.com/apache/flink/pull/9595> > > > > > > > > > > > > > > > > > > > On 2. Sep 2019, at 05:03, Yu Li <car...@gmail.com> > wrote: > > > > > > > > > > > > > > > > > > > > +1 for a 1.8.2 release, thanks for bringing this up > > Jincheng! > > > > > > > > > > > > > > > > > > > > Best Regards, > > > > > > > > > > Yu > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Mon, 2 Sep 2019 at 09:19, Thomas Weise < > t...@apache.org> > > > > > wrote: > > > > > > > > > > > > > > > > > > > >> +1 for the 1.8.2 release > > > > > > > > > >> > > > > > > > > > >> I marked > > https://issues.apache.org/jira/browse/FLINK-13586 > > > for > > > > > this > > > > > > > > > >> release. It would be good to compensate for the backward > > > > > > > incompatible > > > > > > > > > >> change to ClosureCleaner that was introduced in 1.8.1, > > which > > > > > affects > > > > > > > > > >> downstream dependencies. > > > > > > > > > >> > > > > > > > > > >> Thanks, > > > > > > > > > >> Thomas > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > > >> On Sun, Sep 1, 2019 at 5:10 PM jincheng sun < > > > > > > > sunjincheng...@gmail.com> > > > > > > > > > >> wrote: > > > > > > > > > >> > > > > > > > > > >>> Hi Jark, > > > > > > > > > >>> > > > > > > > > > >>> Glad to hear that you want to be the Release Manager of > > > flink > > > > > > > 1.8.2. > > > > > > > > > >>> I believe that you will be a great RM, and I am very > > > willing to > > > > > > > help > > > > > > > > > you > > > > > > > > > >>> with the final release in the final stages. :) > > > > > > > > > >>> > > > > > > > > > >>> The release of Apache Flink involves a number of tasks. > > For > > > > > > > details, > > > > > > > > > you > > > > > > > > > >>> can consult the documentation [1]. If you have any > > > questions, > > > > > > > please > > > > > > > > > let > > > > > > > > > >> me > > > > > > > > > >>> know and let us work together. > > > > > > > > > >>> > > > > > > > > > >>> > > > > > > > > > >>> > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/FLINK/Creating+a+Flink+Release#CreatingaFlinkRelease-Checklisttoproceedtothenextstep.1 > > > > > > > > > >>> > > > > > > > > > >>> Cheers, > > > > > > > > > >>> Jincheng > > > > > > > > > >>> > > > > > > > > > >>> Till Rohrmann <trohrm...@apache.org> 于2019年8月31日周六 > > > 上午12:59写道： > > > > > > > > > >>> > > > > > > > > > >>>> +1 for a 1.8.2 bug fix release. Thanks for kicking > this > > > > > > > discussion off > > > > > > > > > >>>> Jincheng. > > > > > > > > > >>>> > > > > > > > > > >>>> Cheers, > > > > > > > > > >>>> Till > > > > > > > > > >>>> > > > > > > > > > >>>> On Fri, Aug 30, 2019 at 6:45 PM Jark Wu < > > imj...@gmail.com > > > > > > > > > wrote: > > > > > > > > > >>>> > > > > > > > > > >>>>> Thanks Jincheng for bringing this up. > > > > > > > > > >>>>> > > > > > > > > > >>>>> +1 to the 1.8.2 release, because it already contains > a > > > > > couple of > > > > > > > > > >>>> important > > > > > > > > > >>>>> fixes and it has been a long time since 1.8.1 came > out. > > > > > > > > > >>>>> I'm willing to help the community as much as > possible. > > > I'm > > > > > > > wondering > > > > > > > > > >>> if I > > > > > > > > > >>>>> can be the release manager of 1.8.2 or work with you > > > together > > > > > > > > > >>> @Jincheng？ > > > > > > > > > >>>>> > > > > > > > > > >>>>> Best, > > > > > > > > > >>>>> Jark > > > > > > > > > >>>>> > > > > > > > > > >>>>> On Fri, 30 Aug 2019 at 18:58, Hequn Cheng < > > > > > chenghe...@gmail.com> > > > > > > > > > >>> wrote: > > > > > > > > > >>>>> > > > > > > > > > >>>>>> Hi Jincheng, > > > > > > > > > >>>>>> > > > > > > > > > >>>>>> +1 for a 1.8.2 release. > > > > > > > > > >>>>>> Thanks a lot for raising the discussion. It would be > > > nice to > > > > > > > have > > > > > > > > > >>> these > > > > > > > > > >>>>>> critical fixes. > > > > > > > > > >>>>>> > > > > > > > > > >>>>>> Best, Hequn > > > > > > > > > >>>>>> > > > > > > > > > >>>>>> > > > > > > > > > >>>>>> On Fri, Aug 30, 2019 at 6:31 PM Maximilian Michels < > > > > > > > m...@apache.org > > > > > > > > > >>> > > > > > > > > > >>>>> wrote: > > > > > > > > > >>>>>> > > > > > > > > > >>>>>>> Hi Jincheng, > > > > > > > > > >>>>>>> > > > > > > > > > >>>>>>> +1 I would be for a 1.8.2 release such that we can > > fix > > > the > > > > > > > > > >> problems > > > > > > > > > >>>>> with > > > > > > > > > >>>>>>> the nested closure cleaner which currently block > > 1.8.1 > > > > > users > > > > > > > with > > > > > > > > > >>>> Beam: > > > > > > > > > >>>>>>> https://issues.apache.org/jira/browse/FLINK-13367 > > > > > > > > > >>>>>>> > > > > > > > > > >>>>>>> Thanks, > > > > > > > > > >>>>>>> Max > > > > > > > > > >>>>>>> > > > > > > > > > >>>>>>> On 30.08.19 11:25, jincheng sun wrote: > > > > > > > > > >>>>>>>> Hi Flink devs, > > > > > > > > > >>>>>>>> > > > > > > > > > >>>>>>>> It has been nearly 2 months since the 1.8.1 > > released. > > > So, > > > > > what > > > > > > > > > >> do > > > > > > > > > >>>> you > > > > > > > > > >>>>>>> think > > > > > > > > > >>>>>>>> about releasing Flink 1.8.2 soon? > > > > > > > > > >>>>>>>> > > > > > > > > > >>>>>>>> We already have some blocker and critical fixes in > > the > > > > > > > > > >>> release-1.8 > > > > > > > > > >>>>>>> branch: > > > > > > > > > >>>>>>>> > > > > > > > > > >>>>>>>> [Blocker] > > > > > > > > > >>>>>>>> - FLINK-13159 java.lang.ClassNotFoundException > when > > > > > restore > > > > > > > job > > > > > > > > > >>>>>>>> - FLINK-10368 'Kerberized YARN on Docker test' > > > unstable > > > > > > > > > >>>>>>>> - FLINK-12578 Use secure URLs for Maven > repositories > > > > > > > > > >>>>>>>> > > > > > > > > > >>>>>>>> [Critical] > > > > > > > > > >>>>>>>> - FLINK-12736 ResourceManager may release TM with > > > > > allocated > > > > > > > > > >> slots > > > > > > > > > >>>>>>>> - FLINK-12889 Job keeps in FAILING state > > > > > > > > > >>>>>>>> - FLINK-13484 ConnectedComponents end-to-end test > > > instable > > > > > > > with > > > > > > > > > >>>>>>>> NoResourceAvailableException > > > > > > > > > >>>>>>>> - FLINK-13508 CommonTestUtils#waitUntilCondition() > > may > > > > > attempt > > > > > > > > > >> to > > > > > > > > > >>>>> sleep > > > > > > > > > >>>>>>>> with negative time > > > > > > > > > >>>>>>>> - FLINK-13806 Metric Fetcher floods the JM log > with > > > errors > > > > > > > when > > > > > > > > > >>> TM > > > > > > > > > >>>> is > > > > > > > > > >>>>>>> lost > > > > > > > > > >>>>>>>> > > > > > > > > > >>>>>>>> Furthermore, I think the following one blocker > issue > > > > > should be > > > > > > > > > >>>> merged > > > > > > > > > >>>>>>>> before 1.8.2 release. > > > > > > > > > >>>>>>>> > > > > > > > > > >>>>>>>> - FLINK-13897: OSS FS NOTICE file is placed in > wrong > > > > > directory > > > > > > > > > >>>>>>>> > > > > > > > > > >>>>>>>> It would also be great if we can have the fix of > > > > > > > > > >> Elasticsearch6.x > > > > > > > > > >>>>>>> connector > > > > > > > > > >>>>>>>> threads leaking (FLINK-13689) in 1.8.2 release > which > > > is > > > > > > > > > >>> identified > > > > > > > > > >>>> as > > > > > > > > > >>>>>>> major. > > > > > > > > > >>>>>>>> > > > > > > > > > >>>>>>>> Please let me know what you think? > > > > > > > > > >>>>>>>> > > > > > > > > > >>>>>>>> Cheers, > > > > > > > > > >>>>>>>> Jincheng > > > > > > > > > >>>>>>>> > > > > > > > > > >>>>>>> > > > > > > > > > >>>>>> > > > > > > > > > >>>>> > > > > > > > > > >>>> > > > > > > > > > >>> > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
