Nice.

I just would need to get some feedback about it -- I had to change
something in a "hacky way"... Maybe there is a better solution for it...

https://github.com/apache/flink/pull/1387

I there is no better idea about solving the naming issue, I would merge
it into master (there is no 0.10.1 branch yet, right?)

-Matthias

On 11/20/2015 01:54 PM, Till Rohrmann wrote:
> If it' not API breaking, then it can be included imo.
> 
> On Fri, Nov 20, 2015 at 1:44 PM, Matthias J. Sax <mj...@apache.org> wrote:
> 
>> If we find more bugs later on, we could have a 0.10.2, too.
>>
>> +1 for quick bug fix release.
>>
>> Question: should bug fix releases contain fixes for core components
>> only? I would have a fix for a bug in Storm compatibility -- not sure if
>> it should be included or not
>>
>> -Matthias
>>
>> On 11/20/2015 12:35 PM, Till Rohrmann wrote:
>>> The optimizer bug (https://issues.apache.org/jira/browse/FLINK-3052)
>> should
>>> be fixed with https://github.com/apache/flink/pull/1388.
>>>
>>> On Fri, Nov 20, 2015 at 11:37 AM, Gyula Fóra <gyula.f...@gmail.com>
>> wrote:
>>>
>>>> Thanks guys,
>>>>
>>>> I understand your point and you are probably right, if this is a
>>>> lightweight process than the earlier the better :)
>>>>
>>>> Gyula
>>>> On Fri, Nov 20, 2015 at 11:34 AM Ufuk Celebi <u...@apache.org> wrote:
>>>>
>>>>> Hey Gyula,
>>>>>
>>>>> I understand your point, but we already have some important fixes for
>>>>> 0.10.1. It's fair to assume that we will find more issues in the
>> future,
>>>>> but the bugfix releases have way less overhead than the major
>> releases. I
>>>>> would still keep the ASAP schedule and would not wait longer (except
>> for
>>>>> the case that the we find an important issue that we want fixed). We
>> can
>>>>> always do a new bug fix release.
>>>>>
>>>>> – Ufuk
>>>>>
>>>>> On Fri, Nov 20, 2015 at 11:25 AM, Gyula Fóra <gyula.f...@gmail.com>
>>>> wrote:
>>>>>
>>>>>> Hi all,
>>>>>>
>>>>>> Wouldnt you think that it would make sense to wait a week or so to
>> find
>>>>> all
>>>>>> the hot issues with the current release?
>>>>>>
>>>>>> To me it feels a little bit like rushing this out and we will have
>>>> almost
>>>>>> the same situation afterwards.
>>>>>>
>>>>>> I might be wrong but I think people should get a chance to try this
>>>> out.
>>>>>>
>>>>>> In any case I would +1 for the quick release if everyone else thinks
>>>>> thats
>>>>>> the way, these are just my thoughts.
>>>>>>
>>>>>> Gyula
>>>>>> On Fri, Nov 20, 2015 at 11:13 AM Till Rohrmann <trohrm...@apache.org>
>>>>>> wrote:
>>>>>>
>>>>>>> Actually, I still have another bug related to the optimizer which I
>>>>> would
>>>>>>> like to include if possible. The problem is that the optimizer is not
>>>>>> able
>>>>>>> to push properties properly out of a bulk iteration which in some
>>>> cases
>>>>>> can
>>>>>>> lead to rejected Flink jobs.
>>>>>>>
>>>>>>> On Fri, Nov 20, 2015 at 11:10 AM, Robert Metzger <
>>>> rmetz...@apache.org>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> Great, thank you!
>>>>>>>>
>>>>>>>> Let me know if there is any issue, I'll address it asap. The PR is
>>>>> not
>>>>>>>> building anymore because you've pushed an update to the Kafka
>>>>>>>> documentation. I can rebase and merge the PR once you give me green
>>>>>> light
>>>>>>>> ;)
>>>>>>>>
>>>>>>>> Till has merged FLINK-3021, so we might be able to have a first RC
>>>>>> today.
>>>>>>>>
>>>>>>>>
>>>>>>>> On Fri, Nov 20, 2015 at 11:05 AM, Stephan Ewen <se...@apache.org>
>>>>>> wrote:
>>>>>>>>
>>>>>>>>> Let me look at FLINK-2974 (open PR) to see if it can be merged...
>>>>>>>>>
>>>>>>>>> On Thu, Nov 19, 2015 at 10:09 PM, Robert Metzger <
>>>>>> rmetz...@apache.org>
>>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>>> Looks like we didn't manage to merge everything today.
>>>>>>>>>>
>>>>>>>>>> (pending PRs)
>>>>>>>>>> - FLINK-3021 Fix class loading issue for streaming sources
>>>>>>>>>> - FLINK-2974 Add periodic offset committer for Kafka
>>>>>>>>>>
>>>>>>>>>> (merged)
>>>>>>>>>> - FLINK-2977 Using reflection to load HBase Kerberos tokens
>>>>>>>>>> - FLINK-3024 Fix TimestampExtractor.getCurrentWatermark()
>>>>> Behaviour
>>>>>>>>>> - FLINK-2967 Increase timeout for LOCAL_HOST address detection
>>>>>>> stratey
>>>>>>>>>> - FLINK-3025 [kafka consumer] Bump transitive ZkClient
>>>> dependency
>>>>>>>>>> (merged since my first email)
>>>>>>>>>> - FLINK-2989 job cancel button doesn't work on YARN
>>>>>>>>>> - FLINK-3032: Flink does not start on Hadoop 2.7.1 (HDP), due
>>>> to
>>>>>>> class
>>>>>>>>>> conflict
>>>>>>>>>> - FLINK-3011, 3019, 3028 Cancel jobs in RESTARTING state
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Is anybody volunteering to be a release manager?
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> On Thu, Nov 19, 2015 at 10:16 AM, Suneel Marthi <
>>>>>> smar...@apache.org>
>>>>>>>>>> wrote:
>>>>>>>>>>
>>>>>>>>>>> Flink-3017, Flink-3022, and some hotfixes u had put in over
>>>> the
>>>>>>> past
>>>>>>>>> few
>>>>>>>>>>> days.
>>>>>>>>>>>
>>>>>>>>>>> Flink-3041 and Flink-3043 are pending PRs at the moment.
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> On Thu, Nov 19, 2015 at 4:10 AM, Till Rohrmann <
>>>>>>>>> till.rohrm...@gmail.com>
>>>>>>>>>>> wrote:
>>>>>>>>>>>
>>>>>>>>>>>> If they cover things which are also wrongly documented in
>>>>> 0.10,
>>>>>>>> then
>>>>>>>>>> they
>>>>>>>>>>>> should be merged to 0.10-release as well.
>>>>>>>>>>>>
>>>>>>>>>>>> On Thu, Nov 19, 2015 at 10:01 AM, Suneel Marthi <
>>>>>>>>>> suneel.mar...@gmail.com
>>>>>>>>>>>>
>>>>>>>>>>>> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>> @Till Should the recent updates to docs/apis/
>>>>>>> streaming-guide.md
>>>>>>>> be
>>>>>>>>>>> also
>>>>>>>>>>>>> merged to 'release 0.10'? There are other related PRs
>>>>>> pending.
>>>>>>>>>>>>>
>>>>>>>>>>>>> On Thu, Nov 19, 2015 at 3:42 AM, Till Rohrmann <
>>>>>>>>> trohrm...@apache.org
>>>>>>>>>>>
>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>> Yes forgot about merging them to release-0.10. Will do
>>>> it
>>>>>>> right
>>>>>>>>>> away.
>>>>>>>>>>>>>> On Nov 19, 2015 9:40 AM, "Robert Metzger" <
>>>>>>> rmetz...@apache.org
>>>>>>>>>
>>>>>>>>>>> wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> @Suneel, I think
>>>>>>>>>> https://issues.apache.org/jira/browse/FLINK-2949
>>>>>>>>>>>> is a
>>>>>>>>>>>>>> new
>>>>>>>>>>>>>>> feature. The 0.10.1 release is intended as a bugfix
>>>>>> release
>>>>>>>>> only.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> FLINK-3013 and FLINK-3036 have been merged to master
>>>>>> only.
>>>>>>>> Are
>>>>>>>>>>> there
>>>>>>>>>>>>>> plans
>>>>>>>>>>>>>>> to merge it to "release-0.10" as well?
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> The list of issues now looks as follows:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> (pending PRs)
>>>>>>>>>>>>>>> - FLINK-3032: Flink does not start on Hadoop 2.7.1
>>>>> (HDP),
>>>>>>> due
>>>>>>>>> to
>>>>>>>>>>>> class
>>>>>>>>>>>>>>> conflict
>>>>>>>>>>>>>>> - FLINK-3011, 3019, 3028 Cancel jobs in RESTARTING
>>>>> state
>>>>>>>>>>>>>>> - FLINK-3021 Fix class loading issue for streaming
>>>>>> sources
>>>>>>>>>>>>>>> - FLINK-2974 Add periodic offset committer for Kafka
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> (merged)
>>>>>>>>>>>>>>> - FLINK-2977 Using reflection to load HBase Kerberos
>>>>>> tokens
>>>>>>>>>>>>>>> - FLINK-3024 Fix
>>>>> TimestampExtractor.getCurrentWatermark()
>>>>>>>>>> Behaviour
>>>>>>>>>>>>>>> - FLINK-2967 Increase timeout for LOCAL_HOST address
>>>>>>>> detection
>>>>>>>>>>>> stratey
>>>>>>>>>>>>>>> - FLINK-3025 [kafka consumer] Bump transitive
>>>> ZkClient
>>>>>>>>> dependency
>>>>>>>>>>>>>>> (merged since my first email)
>>>>>>>>>>>>>>> - FLINK-2989 job cancel button doesn't work on YARN
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> On Wed, Nov 18, 2015 at 2:35 PM, Ufuk Celebi <
>>>>>>> u...@apache.org
>>>>>>>>>
>>>>>>>>>>> wrote:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> @Suneel: I think that's OK for the next major
>>>> release
>>>>>> :)
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> On Wed, Nov 18, 2015 at 2:17 PM, Suneel Marthi <
>>>>>>>>>>>>>> suneel.mar...@gmail.com>
>>>>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Would be nice to have Flink-2949 in the mix, but
>>>> I
>>>>>>> won't
>>>>>>>> be
>>>>>>>>>>> able
>>>>>>>>>>>> to
>>>>>>>>>>>>>> get
>>>>>>>>>>>>>>>> to
>>>>>>>>>>>>>>>>> it until early next week.
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> On Wed, Nov 18, 2015 at 7:49 AM, Till Rohrmann <
>>>>>>>>>>>>> trohrm...@apache.org
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> @Vasia, do you mean FLINK-3013 or FLINK-3012?
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> Will merge PRs for FLINK-3036 and FLINK-3013
>>>> this
>>>>>>>>>> afternoon.
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> On Wed, Nov 18, 2015 at 1:47 PM, Stephan Ewen <
>>>>>>>>>>>> se...@apache.org>
>>>>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> +1 for a timely 0.10.1 release
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> I would like to add FLINK-2974 - periodic
>>>> kafka
>>>>>>>> offset
>>>>>>>>>>>>> committer
>>>>>>>>>>>>>>> for
>>>>>>>>>>>>>>>>> case
>>>>>>>>>>>>>>>>>>> where checkpointing is deactivated
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> On Wed, Nov 18, 2015 at 12:34 PM, Vasiliki
>>>>>> Kalavri
>>>>>>> <
>>>>>>>>>>>>>>>>>>> vasilikikala...@gmail.com> wrote:
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> Hey,
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> I would also add FLINK-3012 and FLINK-3036
>>>>>> (both
>>>>>>>>>> pending
>>>>>>>>>>>>> PRs).
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> Thanks!
>>>>>>>>>>>>>>>>>>>> -Vasia.
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> On 18 November 2015 at 12:24, Robert
>>>> Metzger
>>>>> <
>>>>>>>>>>>>>>> rmetz...@apache.org>
>>>>>>>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>> Hi,
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>> I was wondering whether we should release
>>>>>> Flink
>>>>>>>>>> 0.10.1
>>>>>>>>>>>>> soon,
>>>>>>>>>>>>>> as
>>>>>>>>>>>>>>>>> there
>>>>>>>>>>>>>>>>>>> are
>>>>>>>>>>>>>>>>>>>>> some issues we've identified:
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>> (pending PRs)
>>>>>>>>>>>>>>>>>>>>> - FLINK-3032: Flink does not start on
>>>>> Hadoop
>>>>>>>> 2.7.1
>>>>>>>>>>> (HDP),
>>>>>>>>>>>>> due
>>>>>>>>>>>>>>> to
>>>>>>>>>>>>>>>>>> class
>>>>>>>>>>>>>>>>>>>>> conflict
>>>>>>>>>>>>>>>>>>>>> - FLINK-3011, 3019, 3028 Cancel jobs in
>>>>>>>> RESTARTING
>>>>>>>>>>> state
>>>>>>>>>>>>>>>>>>>>> - FLINK-3021 Fix class loading issue for
>>>>>>>> streaming
>>>>>>>>>>>> sources
>>>>>>>>>>>>>>>>>>>>> - FLINK-2989 job cancel button doesn't
>>>> work
>>>>>> on
>>>>>>>> YARN
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>> (merged)
>>>>>>>>>>>>>>>>>>>>> - FLINK-2977 Using reflection to load
>>>> HBase
>>>>>>>>> Kerberos
>>>>>>>>>>>> tokens
>>>>>>>>>>>>>>>>>>>>> - FLINK-3024 Fix
>>>>>>>>>>> TimestampExtractor.getCurrentWatermark()
>>>>>>>>>>>>>>>> Behaviour
>>>>>>>>>>>>>>>>>>>>> - FLINK-2967 Increase timeout for
>>>>> LOCAL_HOST
>>>>>>>>> address
>>>>>>>>>>>>>> detection
>>>>>>>>>>>>>>>>>> stratey
>>>>>>>>>>>>>>>>>>>>> - FLINK-3025 [kafka consumer] Bump
>>>>> transitive
>>>>>>>>>> ZkClient
>>>>>>>>>>>>>>> dependency
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>> Anything else that you would like to add?
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>> Do you think we can manage to merge the
>>>>> four
>>>>>>> PRs
>>>>>>>>>> until
>>>>>>>>>>>>>> tomorrow
>>>>>>>>>>>>>>>> and
>>>>>>>>>>>>>>>>>>> then
>>>>>>>>>>>>>>>>>>>>> start the RC?
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>>
> 

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to