Another issue: XML literals and angle brackets.
Is the compiler handling xml literals at all now? I think angle bracket notation need to be converted to string concatenation as well. On Dec 31, 2015, at 5:21 PM, Alex Harui <aha...@adobe.com> wrote: > Sounds reasonable. Do you want to try to make the changes to the compiler > yourself? > > I think you can just copy the pattern in this commit: > 22fa6defa3ed2896de4eba1a5a1b316e1e3c2b0f > In these files: BinaryOperatorEmitter.java and TestFlexJSGlobalClasses.java > > -Alex > > On 12/31/15, 1:02 AM, "Harbs" <harbs.li...@gmail.com> wrote: > >> Another question: >> >> How should we handle equality? According to the E4X spec, if regular >> equality is used, it returns true if the structure of the XML matches >> even if the objects are different objects. So: >> >> var xml1 = <foo><baz /></foo>; >> var xml2 = <foo><baz/></foo>; >> xml1 == xml2 // true >> xml1 === xml2 // false >> xml1 === xml1 // true >> var xml1 = <foo><baz /></foo>; >> var xml2 = <foo><baz name="baz"/></foo>; >> xml1 == xml2 // false >> xml1 === xml2 // false >> xml1 === xml1 // true >> >> I’m thinking I should add an equals(xml) method which you’d map to the >> “==" operator. >
