OK, I looked at the code. It occurred to me that clipping text could be
"dangerous" in that some important words at the end of the alert message
could end up not being shown to the user.
Example: "Are you sure you want to delete? <clipped>This action cannot be
undone</clipped>"
I would recommend adding a static flag about whether to clip or not and
then taking different code paths. I think the tests are failing because
sometimes the calculated height is slightly more than the amount of room
left for the text, but the TextField also has the two pixel gutter at top
and bottom so it sort of works out if the TextField overlaps the button a
bit. By forcing TextField to fit including the gutter things shift a bit,
and if you are off by enough, you'll end up with the Shader test results.
-Alex
On 5/20/14 3:58 PM, "Alex Harui" <aha...@adobe.com> wrote:
>I ran the Shader filter tests. The baseline looks "ok" but with the
>changes, the text is shifted down and obscured by the button. If someone
>else did this same thing, they would probably notice. I'm wondering if
>there is a way to retain old behavior but still fix this bug. I'm going
>to look at the actual code shortly.
>
>-Alex
>
>On 5/20/14 2:50 PM, "Alex Harui" <aha...@adobe.com> wrote:
>
>>I haven't looked at your changes yet. Are you saying that if someone
>>sets
>>explicit dimensions on the Alert that those dimensions may be overruled
>>by
>>this change? Or only if you determine the Alert is too small? Usually,
>>we let folks use their explicit values for whatever reason even if we
>>might consider them "wrong".
>>
>>-Alex
>>
>>On 5/20/14 2:46 PM, "Justin Mclean" <jus...@classsoftware.com> wrote:
>>
>>>Hi,
>>>
>>>> The main question should be: are any of our customers relying on the
>>>>old
>>>> behavior and will be broken by the new behavior. Sometimes, folks
>>>> actually care about a couple of pixels.
>>>
>>>Sure. I't not going to be common but would be possible to effect someone
>>>if they were doing the wrong thing to be out by a few pixels. The height
>>>of the Alter box is less than what it needed to display all of the
>>>content ("hello") correctly so the test is jammed up the text close to
>>>the border and the button. In fact if the test had decenders ie "y" it
>>>would overlap the button.
>>>
>>>When you do have enough height or let it calculate it (99.99% of case
>>>I'd
>>>assume) there doesn't seem to be an issue as far as I can see.
>>>
>>>Thanks,
>>>Justin
>>
>
