On 5/20/14 2:38 PM, "OmPrakash Muppirala" <bigosma...@gmail.com> wrote:
>On Tue, May 20, 2014 at 2:35 PM, Alex Harui <aha...@adobe.com> wrote: > >> The main question should be: are any of our customers relying on the old >> behavior and will be broken by the new behavior. Sometimes, folks >> actually care about a couple of pixels. >> >> >I agree that it is good to be careful, but in this scenario, it seems okay >to modify the test. I can't imagine someone having a big problem with an >Alert box showing a couple of pixels off. Folks have definitely cared about one pixel changes in the past, although not necessarily around alerts. If it affects visual alignment and/or obscuration we might hear some complaints. Other folks may have explicitly set alert height for some reason. Another related question: why did the fix, which I thought was for a specific overflow case, require changing other alerts? -Alex
