I ran the Shader filter tests. The baseline looks "ok" but with the
changes, the text is shifted down and obscured by the button. If someone
else did this same thing, they would probably notice. I'm wondering if
there is a way to retain old behavior but still fix this bug. I'm going
to look at the actual code shortly.
-Alex
On 5/20/14 2:50 PM, "Alex Harui" <aha...@adobe.com> wrote:
>I haven't looked at your changes yet. Are you saying that if someone sets
>explicit dimensions on the Alert that those dimensions may be overruled by
>this change? Or only if you determine the Alert is too small? Usually,
>we let folks use their explicit values for whatever reason even if we
>might consider them "wrong".
>
>-Alex
>
>On 5/20/14 2:46 PM, "Justin Mclean" <jus...@classsoftware.com> wrote:
>
>>Hi,
>>
>>> The main question should be: are any of our customers relying on the
>>>old
>>> behavior and will be broken by the new behavior. Sometimes, folks
>>> actually care about a couple of pixels.
>>
>>Sure. I't not going to be common but would be possible to effect someone
>>if they were doing the wrong thing to be out by a few pixels. The height
>>of the Alter box is less than what it needed to display all of the
>>content ("hello") correctly so the test is jammed up the text close to
>>the border and the button. In fact if the test had decenders ie "y" it
>>would overlap the button.
>>
>>When you do have enough height or let it calculate it (99.99% of case I'd
>>assume) there doesn't seem to be an issue as far as I can see.
>>
>>Thanks,
>>Justin
>
