Alex, Actually, I moved the fixed jar onto the parent jira [1], Alexander attached it his original code and that's the current state of the attached files, so, it should be all what we need. (Sorry for the confusion because I did it in the same time but removed the extra file right after I've seen he did it.)
Thanks, Frédéric THOMAS [1] https://issues.apache.org/jira/browse/FLEX-34042 > From: aha...@adobe.com > To: dev@flex.apache.org > Subject: Re: FDB vs FB debugging ? > Date: Thu, 16 Jan 2014 15:54:15 +0000 > > Well, we need Alexander to attach it so it records it as a donation from > them. > > It is optional whether to put your changes in the JIRA. Folks might > prefer the jar over having the sources, but up to you. > > Thanks to both of you, > -Alex > > On 1/16/14 6:28 AM, "Frédéric THOMAS" <webdoubl...@hotmail.com> wrote: > > >Hi Alex, > > > >Yeah, I'm happy too, to be able to set breakpoints in runtime loaded > >modules now. > > > >I should have attached the idea fix sources, will do it right now and > >move the fixed fdb.jar to the parent issue as it should, in case users > >want to test / use it before the release. > > > >Thanks, > >Frédéric THOMAS > > > >> From: aha...@adobe.com > >> To: dev@flex.apache.org > >> Subject: Re: FDB vs FB debugging ? > >> Date: Thu, 16 Jan 2014 14:22:16 +0000 > >> > >> Yay Fred! Great job! > >> > >> Alexander, can you attach the FDB patches you gave to Fred to one of the > >> JIRA issues? That way we can have a consistent way of tracking your > >> permission to use those patches. > >> > >> Thanks, > >> -Alex > >> > >> On 1/16/14 6:11 AM, "Frédéric THOMAS" <webdoubl...@hotmail.com> wrote: > >> > >> >No problemo, especially because most of those fixes came from you, so, > >> >many thanks to you :-) > >> > > >> >Btw, does it means the idea-fdb-fix will contains only the StringUtil / > >> >ExpressionCache fixes now ? > >> >I didn't integrated this fix because you told me it is more an IDE > >>thing > >> >and I didn't look at it closely, what impact it would be to integrate > >>it > >> >and using FDB standalone ? > >> > > >> >Thanks, > >> >Frédéric THOMAS > >> > > >> >> Date: Thu, 16 Jan 2014 18:00:05 +0400 > >> >> From: alexander.doros...@jetbrains.com > >> >> To: dev@flex.apache.org > >> >> Subject: Re: FDB vs FB debugging ? > >> >> > >> >> Checked in the repo - ok for me, thank you for these fixes! > >> >> > >> >> The problem with ANEs is not stable and depends on the Moon phase. > >>Test > >> >> case was simple - any app with any ANE. I don't remember which one I > >> >> used when was working on the issue. But since you took my code that > >>was > >> >> tested at the moment when I caught the issue, and tested by IntelliJ > >> >> IDEA users for more than a year, it should be ok. > >> >> > >> >> Truly speaking this fix is not 'fair', it is a sort of a workaround > >>for > >> >> the problem that lays somewhere at lower level of the fdb tool or > >> >> debugging protocol. But it is safe and perfectly tested and it works, > >> >>so > >> >> let it be. > >> >> > >> >> Thanks again, > >> >> Alexander > >> >> > >> >> > It is commited already, from the tests I did, it is ok, wanted you > >>to > >> >>check as well, especially for ANE, I've got no test cases for that, > >>Btw, > >> >>if you have, can you share your test cases with me ? it would be > >>great. > >> >> > >> > > >> > > >
