On 04/10/2018 09:47 AM, Wodkowski, PawelX wrote:
-----Original Message-----
From: Maxime Coquelin [mailto:[email protected]]
Sent: Tuesday, April 10, 2018 9:44 AM
To: Wodkowski, PawelX <[email protected]>; Zhang, Roy Fan
<[email protected]>; [email protected]
Cc: [email protected]; Tan, Jianfeng <[email protected]>
Subject: Re: [PATCH] lib/librte_vhost: fix bugs
Hi Pawel,
On 04/10/2018 09:32 AM, Wodkowski, PawelX wrote:
# all source are stored in SRCS-y
SRCS-$(CONFIG_RTE_LIBRTE_VHOST) := fd_man.c iotlb.c socket.c vhost.c
\
diff --git a/lib/librte_vhost/vhost_crypto.c
b/lib/librte_vhost/vhost_crypto.c
index d84513e7f..2acfc908c 100644
--- a/lib/librte_vhost/vhost_crypto.c
+++ b/lib/librte_vhost/vhost_crypto.c
@@ -381,7 +381,7 @@ vhost_crypto_create_sess(struct vhost_crypto
*vcrypto,
return;
}
- VC_LOG_DBG("Session (key %lu, session %p) created.",
+ VC_LOG_DBG("Session (key %llu, session %p) created.",
Why 'llu' instead of PRIu64 (here and there)?
You are right, but Fan actually fixed it in updated version (the initial
patch has been split in 3):
[PATCH] vhost/crypto: fix session id printf
Ohh, sorry. I need more coffee before starting review :)
No problem, that wans't obvious that these 3 patches superseded this
one.
Your reviews are welcome!
Maxime
Cheers,
Maxime
Pawel
Pawel
