Re: [dpdk-dev] [PATCH] vhost/crypto: fix session id printf

[Maxime Coquelin]

On 04/09/2018 08:21 PM, Fan Zhang wrote:

Fixes: 85a2d5cab96f ("vhost/crypto: add virtio-crypto user message structure")

Signed-off-by: Fan Zhang <roy.fan.zh...@intel.com>
---
  lib/librte_vhost/vhost_crypto.c | 14 +++++++-------
  1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/lib/librte_vhost/vhost_crypto.c b/lib/librte_vhost/vhost_crypto.c
index d84513e7f..06c0d3398 100644
--- a/lib/librte_vhost/vhost_crypto.c
+++ b/lib/librte_vhost/vhost_crypto.c
@@ -381,8 +381,8 @@ vhost_crypto_create_sess(struct vhost_crypto *vcrypto,
                return;
        }

- VC_LOG_DBG("Session (key %lu, session %p) created.",

-                       vcrypto->last_session_id, session);
+       VC_LOG_INFO("Session %"PRIu64" created for vdev %i.",
+                       vcrypto->last_session_id, vcrypto->dev->vid);

sess_param->session_id = vcrypto->last_session_id;

        vcrypto->last_session_id++;
@@ -399,17 +399,17 @@ vhost_crypto_close_sess(struct vhost_crypto *vcrypto, 
uint64_t session_id)
                        (void **)&session);

if (unlikely(ret < 0)) {

-               VC_LOG_ERR("Failed to delete session (key %lu).", session_id);
+               VC_LOG_ERR("Failed to delete session %"PRIu64".", session_id);
                return -VIRTIO_CRYPTO_INVSESS;
        }

if (rte_cryptodev_sym_session_clear(vcrypto->cid, session) < 0) {

-               VC_LOG_DBG("Failed to delete session");
+               VC_LOG_DBG("Failed to clear session");
                return -VIRTIO_CRYPTO_ERR;
        }

if (rte_cryptodev_sym_session_free(session) < 0) {

-               VC_LOG_DBG("Failed to delete session");
+               VC_LOG_DBG("Failed to free session");
                return -VIRTIO_CRYPTO_ERR;
        }

@@ -418,8 +418,8 @@ vhost_crypto_close_sess(struct vhost_crypto *vcrypto, uint64_t session_id)

                return -VIRTIO_CRYPTO_ERR;
        }

- VC_LOG_DBG("Session (key %lu, session %p) deleted.", sess_id,

-                       session);
+       VC_LOG_INFO("Session %"PRIu64" deleted for vdev %i.", sess_id,
+                       vcrypto->dev->vid);

return 0;

  }

Acked-by: Maxime Coquelin <maxime.coque...@redhat.com>

I'll squash it with faulty commit if not yet merged by Ferruh.

Thanks,
Maxime