> -----Original Message----- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Saturday, March 31, 2018 3:38 PM > To: Wang, Zhihong <zhihong.w...@intel.com>; dev@dpdk.org > Cc: Tan, Jianfeng <jianfeng....@intel.com>; Bie, Tiwei > <tiwei....@intel.com>; y...@fridaylinux.org; Liang, Cunming > <cunming.li...@intel.com>; Wang, Xiao W <xiao.w.w...@intel.com>; Daly, > Dan <dan.d...@intel.com> > Subject: Re: [PATCH v4 2/5] vhost: support selective datapath > > > > On 03/10/2018 11:01 AM, Zhihong Wang wrote: > > + uint64_t *size); > > +/* Device ops */ > > +struct rte_vdpa_dev_ops { > > + vdpa_dev_queue_num_get_t queue_num_get; > > + vdpa_dev_feature_get_t feature_get; > > + vdpa_dev_feature_get_t protocol_feature_get; > > I would prefer them to be named as in Vhost-user spec: > > get_queue_num > get_features > get_protocol_features
Ok. Will change them. > > Thanks, > Maxime
