> -----Original Message-----
> From: Maxime Coquelin [mailto:[email protected]]
> Sent: Saturday, March 31, 2018 3:38 PM
> To: Wang, Zhihong <[email protected]>; [email protected]
> Cc: Tan, Jianfeng <[email protected]>; Bie, Tiwei
> <[email protected]>; [email protected]; Liang, Cunming
> <[email protected]>; Wang, Xiao W <[email protected]>; Daly,
> Dan <[email protected]>
> Subject: Re: [PATCH v4 2/5] vhost: support selective datapath
> 
> 
> 
> On 03/10/2018 11:01 AM, Zhihong Wang wrote:
> > +           uint64_t *size);
> > +/* Device ops */
> > +struct rte_vdpa_dev_ops {
> > +   vdpa_dev_queue_num_get_t  queue_num_get;
> > +   vdpa_dev_feature_get_t    feature_get;
> > +   vdpa_dev_feature_get_t    protocol_feature_get;
> 
> I would prefer them to be named as in Vhost-user spec:
> 
> get_queue_num
> get_features
> get_protocol_features

Ok. Will change them.

> 
> Thanks,
> Maxime

Reply via email to