> -----Original Message-----
> From: De Lara Guarch, Pablo [mailto:[email protected]]
> Sent: Friday, March 30, 2018 6:36 AM
> To: Zhoujian (jay) <[email protected]>; [email protected]
> Cc: Zhang, Roy Fan <[email protected]>; [email protected]; Gonglei
> (Arei) <[email protected]>; Zeng, Xin <[email protected]>;
> Huangweidong (C) <[email protected]>; wangxin (U)
> <[email protected]>; longpeng <[email protected]>
> Subject: RE: [PATCH v3 5/7] cryptodev: add document for virtio crypto PMD
> 
> 
> 
> > -----Original Message-----
> > From: Jay Zhou [mailto:[email protected]]
> > Sent: Sunday, March 25, 2018 9:34 AM
> > To: [email protected]
> > Cc: De Lara Guarch, Pablo <[email protected]>; Zhang, Roy
> > Fan <[email protected]>; [email protected];
> > [email protected]; Zeng, Xin <[email protected]>;
> > [email protected]; [email protected];
> > [email protected]; [email protected]
> > Subject: [PATCH v3 5/7] cryptodev: add document for virtio crypto PMD
> 
> You should use "doc: add virtio crypto PMD guide"

Okay.

> 
> >
> > Signed-off-by: Jay Zhou <[email protected]>
> > ---
> >  doc/guides/cryptodevs/features/virtio.ini |  22 ++++++
> >  doc/guides/cryptodevs/virtio.rst          | 117
> 
> I tried building the documentation and it fails:
> 
> Warning generate_overview_table(): File 'virtio.ini' has no [AEAD] secton
> /root/dpdk/doc/guides/cryptodevs/virtio.rst: WARNING: document isn't included
> in any toctree
> 
> You should also add a note about this PMD in release notes, but you should
> probably do it in the first patch.
> 

Okay. Will fix all the above.

Regards,
Jay

Reply via email to