> -----Original Message-----
> From: De Lara Guarch, Pablo [mailto:pablo.de.lara.gua...@intel.com]
> Sent: Friday, March 30, 2018 6:36 AM
> To: Zhoujian (jay) <jianjay.z...@huawei.com>; dev@dpdk.org
> Cc: Zhang, Roy Fan <roy.fan.zh...@intel.com>; tho...@monjalon.net; Gonglei
> (Arei) <arei.gong...@huawei.com>; Zeng, Xin <xin.z...@intel.com>;
> Huangweidong (C) <weidong.hu...@huawei.com>; wangxin (U)
> <wangxinxin.w...@huawei.com>; longpeng <longpe...@huawei.com>
> Subject: RE: [PATCH v3 5/7] cryptodev: add document for virtio crypto PMD
> 
> 
> 
> > -----Original Message-----
> > From: Jay Zhou [mailto:jianjay.z...@huawei.com]
> > Sent: Sunday, March 25, 2018 9:34 AM
> > To: dev@dpdk.org
> > Cc: De Lara Guarch, Pablo <pablo.de.lara.gua...@intel.com>; Zhang, Roy
> > Fan <roy.fan.zh...@intel.com>; tho...@monjalon.net;
> > arei.gong...@huawei.com; Zeng, Xin <xin.z...@intel.com>;
> > weidong.hu...@huawei.com; wangxinxin.w...@huawei.com;
> > longpe...@huawei.com; jianjay.z...@huawei.com
> > Subject: [PATCH v3 5/7] cryptodev: add document for virtio crypto PMD
> 
> You should use "doc: add virtio crypto PMD guide"

Okay.

> 
> >
> > Signed-off-by: Jay Zhou <jianjay.z...@huawei.com>
> > ---
> >  doc/guides/cryptodevs/features/virtio.ini |  22 ++++++
> >  doc/guides/cryptodevs/virtio.rst          | 117
> 
> I tried building the documentation and it fails:
> 
> Warning generate_overview_table(): File 'virtio.ini' has no [AEAD] secton
> /root/dpdk/doc/guides/cryptodevs/virtio.rst: WARNING: document isn't included
> in any toctree
> 
> You should also add a note about this PMD in release notes, but you should
> probably do it in the first patch.
> 

Okay. Will fix all the above.

Regards,
Jay

Reply via email to