Wednesday, March 21, 2018 1:37 PM, Andrew Rybchenko: > On 03/21/2018 02:23 PM, Shahaf Shuler wrote: > > > > Wednesday, March 21, 2018 1:20 PM, *:*Andrew Rybchenko > > > > >Not exactly. We should add statement to allow to enable queue > > >offloads on port level (to enable on all queues). > > > > Why it is needed ? > > > > May be just a paranoia to avoid misreading/misunderstanding. > > > Queue offload is also a port offload, for the simple case it is > > enabled on each of the queues. > > > > PMDs should report rx[tx]_offload_capa = port_offloads | > > queue_offloads > > > > So from the application side it enables a **port** offload which, by > > definition, will set the offload to each of the queues. > > > > it is not “enabling queue offload on the port”. > > > > I think it would be really useful for understanding to highlight that what is > enabled on port level is enabled on all queues regardless queue conf.
So I think the extra wording should explain that queue offload is also a port offload, and not to mix between the queue and port offload configuration.
