Hi Anatoly,
> -----Original Message-----
> From: Burakov, Anatoly
> Sent: Tuesday, February 27, 2018 10:36 PM
> To: dev@dpdk.org
> Cc: Tan, Jianfeng
> Subject: [PATCH v3 5/5] eal: don't hardcode socket filter value in IPC
>
> Currently, filter value is hardcoded and disconnected from actual
> value returned by eal_mp_socket_path().
I can understand the hardcode is not good. But why it's not consistent with the
actual value returned from eal_mp_socket_path()?
> Fix this to generate filter
> value by deriving it from eal_mp_socket_path() instead.
>
> Signed-off-by: Anatoly Burakov <anatoly.bura...@intel.com>
Anyway, I think your way looks good to me, so
Acked-by: Jianfeng Tan <jianfeng....@intel.com>
Thanks,
Jianfeng
> ---
>
> Notes:
> v3: no changes
>
> v2: no changes
>
> lib/librte_eal/common/eal_common_proc.c | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/lib/librte_eal/common/eal_common_proc.c
> b/lib/librte_eal/common/eal_common_proc.c
> index 7856a7b..4cf3aa6 100644
> --- a/lib/librte_eal/common/eal_common_proc.c
> +++ b/lib/librte_eal/common/eal_common_proc.c
> @@ -506,16 +506,17 @@ int
> rte_mp_channel_init(void)
> {
> char thread_name[RTE_MAX_THREAD_NAME_LEN];
> - char *path;
> + char path[PATH_MAX];
> int dir_fd;
> pthread_t tid;
>
> - snprintf(mp_filter, PATH_MAX, ".%s_unix_*",
> - internal_config.hugefile_prefix);
> + /* create filter path */
> + create_socket_path("*", path, sizeof(path));
> + snprintf(mp_filter, sizeof(mp_filter), "%s", basename(path));
>
> - path = strdup(eal_mp_socket_path());
> - snprintf(mp_dir_path, PATH_MAX, "%s", dirname(path));
> - free(path);
> + /* path may have been modified, so recreate it */
> + create_socket_path("*", path, sizeof(path));
> + snprintf(mp_dir_path, sizeof(mp_dir_path), "%s", dirname(path));
>
> /* lock the directory */
> dir_fd = open(mp_dir_path, O_RDONLY);
> --
> 2.7.4
