Hi Harry, Thanks for the review, comments below.
On Tue, Dec 19, 2017 at 03:27:25PM +0000, Van Haaren, Harry wrote: > > From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > > Sent: Thursday, December 14, 2017 3:02 PM > > To: jerin.ja...@caviumnetworks.com; santosh.shu...@caviumnetworks.com; > > Richardson, Bruce <bruce.richard...@intel.com>; Van Haaren, Harry > > <harry.van.haa...@intel.com>; Eads, Gage <gage.e...@intel.com>; > > hemant.agra...@nxp.com; nipun.gu...@nxp.com; Ma, Liang J > > <liang.j...@intel.com> > > [Side note: we shouldn't put everybody on CC all the time..] > > > Cc: dev@dpdk.org; Pavan Nikhilesh <pbhagavat...@caviumnetworks.com> > > Subject: [dpdk-dev] [PATCH v2 10/11] test: register eventdev selftest > > > > Signed-off-by: Pavan Nikhilesh <pbhagavat...@caviumnetworks.com> > > > > diff --git a/test/test/test_eventdev.c b/test/test/test_eventdev.c > > index 1ed2a1ddd..b86efab01 100644 > > --- a/test/test/test_eventdev.c > > +++ b/test/test/test_eventdev.c > > @@ -1009,4 +1009,11 @@ test_eventdev_common(void) > > return unit_test_suite_runner(&eventdev_common_testsuite); > > } > > > > +static int > > +test_eventdev_selftest(void) > > +{ > > + return rte_event_dev_selftest(TEST_DEV_ID); > > +} > > + > > REGISTER_TEST_COMMAND(eventdev_common_autotest, test_eventdev_common); > > +REGISTER_TEST_COMMAND(eventdev_selftest, test_eventdev_selftest); > > > Currently when running the test app, we don't pass any arguments. Running the > "eventdev_sw_autotest" command, it will create the required event_sw0 PMD > vdev, and launch the tests then. > > Given the selftest is PMD agnostic, does it makes sense to have a single > string "sw" or "octeontx" to run the tests against? Right now it requires > that we pass ./app/test --vdev event_sw0 which I think is a burden, > particularly when automating this with the meson test infrastructure down the > line. > > Summary; Please add a string parameter that indicates the PMD to run the > self-test on. > We can't pass extra parameter while running test (it will only accept test name). So, I will register pmd specific test test_eventdev_sw/octeontx which will create the eventdev and call the selftest API. Also, I have mistakenly changed the name from event_sw0 to event_sw do you want me to revert it? or retain the change. Cheers, Pavan.
