On Mon, 18 Dec 2017 17:46:21 +0100
Adrien Mazarguil <adrien.mazarg...@6wind.com> wrote:
> +#ifdef RTE_LIBRTE_HYPERV_DEBUG
> +
> +#define PMD_DRV_LOG(level, ...) \
> + RTE_LOG(level, PMD, \
> + RTE_FMT("%s:%u: %s(): " RTE_FMT_HEAD(__VA_ARGS__,) "\n", \
> + strrchr("/" __FILE__, '/') + 1, \
> + __LINE__, \
> + __func__, \
> + RTE_FMT_TAIL(__VA_ARGS__,)))
> +
> +#else /* RTE_LIBRTE_HYPERV_DEBUG */
> +
> +#define PMD_DRV_LOG(level, ...) \
> + RTE_LOG(level, PMD, \
> + RTE_FMT(RTE_STR(HYPERV_DRIVER) ": " \
> + RTE_FMT_HEAD(__VA_ARGS__,) "\n", \
> + RTE_FMT_TAIL(__VA_ARGS__,)))
> +
> +#endif /* RTE_LIBRTE_HYPERV_DEBUG */
> +
> +#define DEBUG(...) PMD_DRV_LOG(DEBUG, __VA_ARGS__)
> +#define INFO(...) PMD_DRV_LOG(INFO, __VA_ARGS__)
> +#define WARN(...) PMD_DRV_LOG(WARNING, __VA_ARGS__)
> +#define ERROR(...) PMD_DRV_LOG(ERR, __VA_ARGS__)
> +
Please don't use DEBUG() etc macros. It makes it easier for tools that do
global updates or scans if all drivers use the same model of PMD_DRV_LOG
