Hi Ferruh, I was absent from the code review John Miller and Ed Czeck held for earlier this week for this patch set. John and Ed are both on a long weekend this weekend. If my reply below is correct and sufficient, please ack this patch set. Otherwise, no reply is needed and please hold this open until next Monday when John will respond.
The Arkville net/ark PMD has the unique challenge of supporting a plurality of MACs through singleton ingress and egress AXI interfaces in hardware. Arkville is in the DPDK business of mbuf structures and data-moving; and does not itself have a concept of line-rate, MTU, and other MAC-centric properties. The extension calls, and the unique user data for each port in the extension calls provide users of Arkville and the net/ark PMD a DPDK normalized way of accessing their MAC parameters, regardless of how many MACs they have instanced in their Arkville DPDK device. -Shep Shepard Siegel, CTO atomicrules.com On Fri, Jun 23, 2017 at 5:21 AM, Ferruh Yigit <ferruh.yi...@intel.com> wrote: > On 6/22/2017 1:30 PM, John Miller wrote: > > Provide unique user data pointer in the extension calls for > > each port. > > Hi John, > > Can you please give more details about why this is done. I can see in > adapter data user_data pointer kept per port now, but why? What was > observed with previous code? If this is to fix something, what we should > expect to be fixed? > > And there is mtu_set implementation, is it related modification? Can be > separated to another patch? > > Thanks, > ferruh > > > > > Signed-off-by: John Miller <john.mil...@atomicrules.com> > > <...> > >
