Hi Bernard: > -----Original Message----- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bernard Iremonger > Sent: Tuesday, April 11, 2017 11:01 PM > To: dev@dpdk.org > Cc: Xing, Beilei <beilei.x...@intel.com>; Lu, Wenzhuo > <wenzhuo...@intel.com>; Zhang, Qi <qi.zh...@intel.com>; Iremonger, > Bernard <bernard.iremon...@intel.com> > Subject: [dpdk-dev] [PATCH] net/i40e: fix to ensure vector mode is not used > > In rx vector mode, the QinQ VLAN tag is not stripped. > When hw_vlan_extend is set for QinQ ensure that rx vector mode is not > selected. > > Fixes: ca74903b75cf ("net/i40e: extract non-x86 specific code from vector > driver")
Why fixes? I didn't see above commit change rx callback function if hw_vlan_extend == 1 > > Signed-off-by: Bernard Iremonger <bernard.iremon...@intel.com> > --- > drivers/net/i40e/i40e_rxtx_vec_common.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/net/i40e/i40e_rxtx_vec_common.h > b/drivers/net/i40e/i40e_rxtx_vec_common.h > index 952fd4b63..692096684 100644 > --- a/drivers/net/i40e/i40e_rxtx_vec_common.h > +++ b/drivers/net/i40e/i40e_rxtx_vec_common.h > @@ -234,6 +234,10 @@ > i40e_rx_vec_dev_conf_condition_check_default(struct rte_eth_dev *dev) > if (rxmode->header_split == 1) > return -1; > > + /* no QinQ support */ > + if (rxmode->hw_vlan_extend == 1) > + return -1; > + > return 0; > #else > RTE_SET_USED(dev); > -- > 2.11.0
